GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.57k stars 278 forks source link

PR n°1 : Add support for NRV module type - Energy / Valves #2014

Closed Terdious closed 7 months ago

Terdious commented 7 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add support for NRV module type - Energy / Valves

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2c1d2a4) 98.30% compared to head (ba9e98f) 98.31%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2014 +/- ## ======================================= Coverage 98.30% 98.31% ======================================= Files 833 834 +1 Lines 13176 13219 +43 ======================================= + Hits 12953 12996 +43 Misses 223 223 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 7 months ago

Job #2366: Bundle Size — 9.83MiB (+0.14%).

ba9e98f(current) vs 2c1d2a4 master#2364(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
Job #2366
     Baseline
Job #2364
Regression  Initial JS 5.34MiB(~+0.01%) 5.34MiB
No change  Initial CSS 303.16KiB 303.16KiB
Change  Cache Invalidation 54.99% 54.28%
No change  Chunks 51 51
Change  Assets 165(+0.61%) 164
No change  Modules 1454 1454
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.8% 0.8%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  Change 3 changes Regression 3 regressions
|            |       Current
[Job #2366](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2366-G6WszcFKoBnpSLEz5Klo?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #2364](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2364-uvBEATP4nCRCv9IlsMDv?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2366-G6WszcFKoBnpSLEz5Klo/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.03MiB` (`~+0.01%`) | `7.03MiB` | | Regression  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2366-G6WszcFKoBnpSLEz5Klo/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.37MiB` (`+0.57%`) | `2.36MiB` | | Not changed  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2366-G6WszcFKoBnpSLEz5Klo/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.67KiB` | `319.67KiB` | | Not changed  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2366-G6WszcFKoBnpSLEz5Klo/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | Regression  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2366-G6WszcFKoBnpSLEz5Klo/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `16.93KiB` (`+0.65%`) | `16.82KiB` | | Not changed  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2366-G6WszcFKoBnpSLEz5Klo/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

View job #2366 reportView Terdious:netatmo-valve-nrv branch activityView project dashboard