Closed Terdious closed 7 months ago
@Pierre-Gilles, I added a "Noise" category for ambient noise sensors. Should I add a device in the demo? Do I need to update the documentation or can we wait until I finish the full weather station?
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
d6dfdc9
) 98.30% compared to head (40021a8
) 98.32%. Report is 5 commits behind head on master.:exclamation: Current head 40021a8 differs from pull request most recent head 5dcb5ab. Consider uploading reports for the commit 5dcb5ab to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
5dcb5ab(current) vs 2c1d2a4 master#2364(baseline)
[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages
Bundle metrics
4 changes
2 regressions
Current Job #2368 |
Baseline Job #2364 |
|
---|---|---|
Initial JS | 5.35MiB (+0.1% ) |
5.34MiB |
Initial CSS | 303.21KiB (+0.02% ) |
303.16KiB |
Cache Invalidation | 58.01% |
54.28% |
Chunks | 51 |
51 |
Assets | 165 (+0.61% ) |
164 |
Modules | 1454 |
1454 |
Duplicate Modules | 20 |
20 |
Duplicate Code | 0.8% |
0.8% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
4 changes
4 regressions
View job #2368 report View Terdious:netatmo-weather-namain branch activity View project dashboard
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Add support for NAMain module type - Weather / Smart Home Weather Station