GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.67k stars 282 forks source link

[WIP] PR n°2 : Add support for NAMain module type - Weather / Smart Home Weather Station #2015

Closed Terdious closed 7 months ago

Terdious commented 9 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add support for NAMain module type - Weather / Smart Home Weather Station

Terdious commented 9 months ago

@Pierre-Gilles, I added a "Noise" category for ambient noise sensors. Should I add a device in the demo? Do I need to update the documentation or can we wait until I finish the full weather station?

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d6dfdc9) 98.30% compared to head (40021a8) 98.32%. Report is 5 commits behind head on master.

:exclamation: Current head 40021a8 differs from pull request most recent head 5dcb5ab. Consider uploading reports for the commit 5dcb5ab to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2015 +/- ## ========================================== + Coverage 98.30% 98.32% +0.01% ========================================== Files 833 836 +3 Lines 13176 13275 +99 ========================================== + Hits 12953 13052 +99 Misses 223 223 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 9 months ago

Job #2368: Bundle Size — 9.84MiB (+0.22%).

5dcb5ab(current) vs 2c1d2a4 master#2364(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 2 regressions
                 Current
Job #2368
     Baseline
Job #2364
Regression  Initial JS 5.35MiB(+0.1%) 5.34MiB
Regression  Initial CSS 303.21KiB(+0.02%) 303.16KiB
Change  Cache Invalidation 58.01% 54.28%
No change  Chunks 51 51
Change  Assets 165(+0.61%) 164
No change  Modules 1454 1454
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.8% 0.8%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  Change 4 changes Regression 4 regressions
|            |       Current
[Job #2368](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2368-evtZoxHG9ngNCiwK3dxN?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #2364](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2364-uvBEATP4nCRCv9IlsMDv?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2368-evtZoxHG9ngNCiwK3dxN/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.04MiB` (`+0.08%`) | `7.03MiB` | | Regression  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2368-evtZoxHG9ngNCiwK3dxN/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.37MiB` (`+0.67%`) | `2.36MiB` | | Regression  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2368-evtZoxHG9ngNCiwK3dxN/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.71KiB` (`+0.01%`) | `319.67KiB` | | Not changed  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2368-evtZoxHG9ngNCiwK3dxN/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | Regression  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2368-evtZoxHG9ngNCiwK3dxN/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `16.93KiB` (`+0.69%`) | `16.82KiB` | | Not changed  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2368-evtZoxHG9ngNCiwK3dxN/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

View job #2368 reportView Terdious:netatmo-weather-namain branch activityView project dashboard