GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.57k stars 278 forks source link

Grouping of PRs 2 to 6: Addition of Weather functionality #2021

Closed Terdious closed 6 months ago

Terdious commented 7 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Grouping of PRs 1 to 6: Addition of complete Weather functionality

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.37%. Comparing base (185fe8a) to head (c44342e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2021 +/- ## ========================================== + Coverage 98.32% 98.37% +0.05% ========================================== Files 836 844 +8 Lines 13269 13695 +426 ========================================== + Hits 13047 13473 +426 Misses 222 222 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 7 months ago

Job #2391: Bundle Size — 9.95MiB (+1.15%).

c44342e(current) vs 185fe8a master#2390(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Regression 2 regressions Improvement 1 improvement
                 Current
Job #2391
     Baseline
Job #2390
Regression  Initial JS 5.36MiB(+0.32%) 5.34MiB
Regression  Initial CSS 303.21KiB(+0.02%) 303.16KiB
Change  Cache Invalidation 57.93% 0%
No change  Chunks 51 51
Change  Assets 170(+3.03%) 165
No change  Modules 1454 1454
No change  Duplicate Modules 20 20
Improvement  Duplicate Code 0.79%(-1.25%) 0.8%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  Change 4 changes Regression 4 regressions
|            |       Current
[Job #2391](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2391-20J2SC7MPU6L7lGxmkMq?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #2390](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2390-LUGnxp8DQHJepqDwNbWk?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2391-20J2SC7MPU6L7lGxmkMq/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.05MiB` (`+0.26%`) | `7.03MiB` | | Regression  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2391-20J2SC7MPU6L7lGxmkMq/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.46MiB` (`+3.99%`) | `2.37MiB` | | Regression  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2391-20J2SC7MPU6L7lGxmkMq/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.71KiB` (`+0.01%`) | `319.67KiB` | | Not changed  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2391-20J2SC7MPU6L7lGxmkMq/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | Regression  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2391-20J2SC7MPU6L7lGxmkMq/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.53KiB` (`+3.54%`) | `16.93KiB` | | Not changed  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2391-20J2SC7MPU6L7lGxmkMq/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

View job #2391 reportView Terdious:netatmo-features-nrv-we... branch activityView project dashboard