To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
[x] If your changes affects code, did your write the tests?
[x] Are tests passing? (npm test on both front/server)
[x] Is the linter passing? (npm run eslint on both front/server)
[x] Did you run prettier? (npm run prettier on both front/server)
[x] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
[x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
[ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.
NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Grouping of PRs 1 to 6: Addition of complete Weather functionality
PR n°1 : Add support for NRV module type - Energy / Valves
PR n°2 : Add support for NAMain module type - Weather / Smart Home Weather Station
PR n°3 : Add support for NAModule4 type - Weather API / Smart Indoor Module
PR n°4 : Add support for NAModule1 type - Weather API / Smart Outdoor Module
PR n°5 : Add support for NAModule2 type - Weather / Smart Anemometer Module
PR n°6 : Add support for NAModule3 type - Weather / Smart Rain Gauge Module
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Grouping of PRs 1 to 6: Addition of complete Weather functionality
PR n°1 : Add support for NRV module type - Energy / Valves