search

GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.57k stars 278 forks source link

chore(eslint): Add no-console rule + clean #2023

Closed cicoub13 closed 7 months ago

cicoub13 commented 7 months ago

Following discussion on French Community, we decide to add a rule to forbid console.log() in Frontend.

I decided to allow console.error() to help in case of error

relativeci[bot] commented 7 months ago

Job #2347: Bundle Size — 9.82MiB (~-0.01%).

80c7272(current) vs 3c38e31 master#2340(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
Job #2347		      Baseline
Job #2340
Improvement  Initial JS 5.34MiB(~-0.01%) 5.34MiB
No change  Initial CSS 303.16KiB 303.16KiB
Change  Cache Invalidation 63.09% 0%
No change  Chunks 51 51
No change  Assets 164 164
No change  Modules 1454 1454
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.8% 0.8%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  Change 1 change Improvement 1 improvement
|            |       Current
[Job #2347](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2347-2EOtaNtIa8ju7wvZrHdk?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #2340](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2340-R2Lv8p7RL3CDy0RFGIaS?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Improvement  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2347-2EOtaNtIa8ju7wvZrHdk/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.03MiB` (`~-0.01%`) | `7.03MiB` | | Not changed  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2347-2EOtaNtIa8ju7wvZrHdk/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.36MiB` | `2.36MiB` | | Not changed  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2347-2EOtaNtIa8ju7wvZrHdk/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.67KiB` | `319.67KiB` | | Not changed  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2347-2EOtaNtIa8ju7wvZrHdk/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | Not changed  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2347-2EOtaNtIa8ju7wvZrHdk/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `16.82KiB` | `16.82KiB` | | Not changed  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2347-2EOtaNtIa8ju7wvZrHdk/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

View job #2347 report View cicoub13:chore-eslint-console-fr... branch activity View project dashboard

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3c38e31) 98.30% compared to head (80c7272) 98.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2023 +/- ## ======================================= Coverage 98.30% 98.30% ======================================= Files 833 833 Lines 13176 13176 ======================================= Hits 12953 12953 Misses 223 223 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.