GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.57k stars 278 forks source link

[Zwavejs-ui] add selector when converting zwave device to Gladys device #2030

Closed William-De71 closed 6 months ago

William-De71 commented 6 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Without selector there is a conflict issue when adding zwave device to Gladys so I propose to add selector when converting Zwave device to Gladys device.

image image

With the selector image

https://community.gladysassistant.com/t/evolution-du-service-z-wave-js-ui/8692/26

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3a3d166) 98.32% compared to head (ca923d2) 98.32%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2030 +/- ## ======================================= Coverage 98.32% 98.32% ======================================= Files 836 836 Lines 13269 13269 ======================================= Hits 13047 13047 Misses 222 222 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 6 months ago

Job #2387: Bundle Size — 9.83MiB (0%).

ca923d2(current) vs 3a3d166 master#2381(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #2387
     Baseline
Job #2381
No change  Initial JS 5.34MiB 5.34MiB
No change  Initial CSS 303.16KiB 303.16KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 51 51
No change  Assets 165 165
No change  Modules 1454 1454
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.8% 0.8%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  no changes
|            |       Current
[Job #2387](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2387-rEABCOBtk2rmW8XntZHi?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #2381](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2381-nHIc6idGPRt0wniAgaiG?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Not changed  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2387-rEABCOBtk2rmW8XntZHi/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.03MiB` | `7.03MiB` | | Not changed  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2387-rEABCOBtk2rmW8XntZHi/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.37MiB` | `2.37MiB` | | Not changed  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2387-rEABCOBtk2rmW8XntZHi/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.67KiB` | `319.67KiB` | | Not changed  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2387-rEABCOBtk2rmW8XntZHi/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | Not changed  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2387-rEABCOBtk2rmW8XntZHi/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `16.93KiB` | `16.93KiB` | | Not changed  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2387-rEABCOBtk2rmW8XntZHi/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

View job #2387 reportView William-De71:zwave_selector branch activityView project dashboard