Closed William-De71 closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
3a3d166
) 98.32% compared to head (ca923d2
) 98.32%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
ca923d2(current) vs 3a3d166 master#2381(baseline)
[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages
Bundle metrics
no changes
Current Job #2387 |
Baseline Job #2381 |
|
---|---|---|
5.34MiB |
5.34MiB |
|
303.16KiB |
303.16KiB |
|
0% |
0% |
|
51 |
51 |
|
165 |
165 |
|
1454 |
1454 |
|
20 |
20 |
|
0.8% |
0.8% |
|
124 |
124 |
|
3 |
3 |
no changes
View job #2387 report View William-De71:zwave_selector branch activity View project dashboard
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Without selector there is a conflict issue when adding zwave device to Gladys so I propose to add selector when converting Zwave device to Gladys device.
With the selector![image](https://github.com/GladysAssistant/Gladys/assets/11477113/2c583b22-2cfb-4780-95d5-1893fbac3035)
https://community.gladysassistant.com/t/evolution-du-service-z-wave-js-ui/8692/26