Closed William-De71 closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.38%. Comparing base (
dd35b83
) to head (ddf5205
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
ddf5205(current) vs dd35b83 master#2405(baseline)
[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages
Bundle metrics
3 changes
1 regression
Current Job #2408 |
Baseline Job #2405 |
|
---|---|---|
Initial JS | 5.36MiB (+0.07% ) |
5.36MiB |
Initial CSS | 303.21KiB |
303.21KiB |
Cache Invalidation | 62.73% |
53.74% |
Chunks | 51 |
51 |
Assets | 170 |
170 |
Modules | 1456 (+0.07% ) |
1455 |
Duplicate Modules | 20 |
20 |
Duplicate Code | 0.79% |
0.79% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
1 change
1 regression
View job #2408 report View William-De71:zwave-location branch activity View project dashboard
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Add zwavejs-ui location to gladys device