[WIP] PR n°7 : Add support for NACamera type - Home+Security / Indoor Camera

Terdious commented 7 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

[ ] If your changes affects code, did your write the tests?
[ ] Are tests passing? (npm test on both front/server)
[ ] Is the linter passing? (npm run eslint on both front/server)
[ ] Did you run prettier? (npm run prettier on both front/server)
[ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
[ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
[ ] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
[ ] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
[ ] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add support for NACamera module type - Home+Security / Indoor Camera

relativeci[bot] commented 7 months ago

#2739 Bundle Size — 10.22MiB (+0.31%).

25856f8(current) vs 1f7617c master#2731(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics 3 changes 1 regression

	Current #2739	Baseline #2731
Initial JS	`5.51MiB`(`+0.13%`)	`5.5MiB`
Initial CSS	`303.12KiB`	`303.12KiB`
Cache Invalidation	`54.55%`	`0%`
Chunks	`51`	`51`
Assets	`172`(`+0.58%`)	`171`
Modules	`1490`	`1490`
Duplicate Modules	`21`	`21`
Duplicate Code	`0.83%`	`0.83%`
Packages	`124`	`124`
Duplicate Packages	`3`	`3`

Bundle size by type Change

3 changes

3 regressions

| | Current
[#2739](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2739-e0KW3MLMRoCuL4m3Dixj?utm_source=github&utm_medium=pr-report "View bundle analysis report") | Baseline
[#2731](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2731-xTUitWhsT85kTGplpCfs?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2739-e0KW3MLMRoCuL4m3Dixj/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.29MiB` (`+0.1%`) | `7.28MiB` | | [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2739-e0KW3MLMRoCuL4m3Dixj/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.5MiB` (`+0.98%`) | `2.48MiB` | | No change

[CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2739-e0KW3MLMRoCuL4m3Dixj/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.91KiB` | `319.91KiB` | | No change

[Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2739-e0KW3MLMRoCuL4m3Dixj/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2739-e0KW3MLMRoCuL4m3Dixj/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.74KiB` (`+0.68%`) | `17.62KiB` | | No change

[HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2739-e0KW3MLMRoCuL4m3Dixj/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

Bundle analysis report Branch Terdious:netatmo-security-nacame... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

GladysAssistant / Gladys