GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.57k stars 278 forks source link

Add siren neo nas-ab02b2 #2034

Closed William-De71 closed 5 months ago

William-De71 commented 6 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add all expose of Neo siren model NAS AB02B2

image

image

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.38%. Comparing base (94fb118) to head (5329ad3). Report is 8 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2034 +/- ## ======================================= Coverage 98.38% 98.38% ======================================= Files 844 844 Lines 13738 13753 +15 ======================================= + Hits 13516 13531 +15 Misses 222 222 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 6 months ago

Job #2445: Bundle Size — 10.04MiB (+0.05%).

5329ad3(current) vs 0ebc8c2 master#2442(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
Job #2445
     Baseline
Job #2442
Regression  Initial JS 5.37MiB(+0.02%) 5.37MiB
No change  Initial CSS 303.21KiB 303.21KiB
Change  Cache Invalidation 62.77% 0%
No change  Chunks 51 51
No change  Assets 170 170
Change  Modules 1458(+0.07%) 1457
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.78% 0.78%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  Change 1 change Regression 1 regression
|            |       Current
[Job #2445](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2445-EE6Z4WXLWgWuKWVW4cZ4?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #2442](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2442-h9Z8krvdy7g0YeNS9KwZ?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2445-EE6Z4WXLWgWuKWVW4cZ4/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.14MiB` (`+0.06%`) | `7.13MiB` | | Not changed  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2445-EE6Z4WXLWgWuKWVW4cZ4/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.46MiB` | `2.46MiB` | | Not changed  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2445-EE6Z4WXLWgWuKWVW4cZ4/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.71KiB` | `319.71KiB` | | Not changed  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2445-EE6Z4WXLWgWuKWVW4cZ4/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | Not changed  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2445-EE6Z4WXLWgWuKWVW4cZ4/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.53KiB` | `17.53KiB` | | Not changed  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2445-EE6Z4WXLWgWuKWVW4cZ4/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

View job #2445 reportView William-De71:add-siren-Neo-NAS-A... branch activityView project dashboard

Pierre-Gilles commented 6 months ago

@atrovato I'm curious to have your feedback on this PR :) Especially on the way that the "melody" enum is handled

William-De71 commented 5 months ago

@atrovato

melody mgmt looks great according to z2m specifications, but, according to my feeling, it will introduce the "enum values" on gladys features to be able to handle named values (but keep working with numerics)

And how do you think we handle that?

Pierre-Gilles commented 5 months ago

@William-De71 Let me know (on the forum) when @atrovato feedbacks are fixed :)

it will introduce the "enum values" on gladys features

For that, it's not really the topic here imo. If the melody management is good for you @atrovato, I'm good to merge after the 2 feedbacks are corrected