GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.57k stars 278 forks source link

Fix initial map bounding #2042

Closed GziAzman closed 5 months ago

GziAzman commented 5 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

CF #2041

Note: This is my first pull request ever, if I made a mistake, I'd be glad if you direct me πŸ™‚

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.38%. Comparing base (9d50528) to head (eeb423e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2042 +/- ## ======================================= Coverage 98.38% 98.38% ======================================= Files 844 844 Lines 13743 13743 ======================================= Hits 13521 13521 Misses 222 222 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 5 months ago

Job #2428: Bundle Size β€” 9.96MiB (~+0.01%).

eeb423e(current) vs 9d50528 master#2423(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
Job #2428
     Baseline
Job #2423
No change  Initial JS 5.37MiB 5.37MiB
No change  Initial CSS 303.21KiB 303.21KiB
Change  Cache Invalidation 53.91% 53.8%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1457 1457
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.79% 0.79%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  Change 1 change Regression 1 regression
|            |       Current
[Job #2428](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2428-lUIWkzdr4xFSTEbyUf6K?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #2423](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2423-TO3m3lKxL13R6R6qCKmP?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2428-lUIWkzdr4xFSTEbyUf6K/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.06MiB` (`~+0.01%`) | `7.06MiB` | | Not changed  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2428-lUIWkzdr4xFSTEbyUf6K/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.46MiB` | `2.46MiB` | | Not changed  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2428-lUIWkzdr4xFSTEbyUf6K/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.71KiB` | `319.71KiB` | | Not changed  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2428-lUIWkzdr4xFSTEbyUf6K/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | Not changed  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2428-lUIWkzdr4xFSTEbyUf6K/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.53KiB` | `17.53KiB` | | Not changed  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2428-lUIWkzdr4xFSTEbyUf6K/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

View job #2428 report View GziAzman:fix-map-initial-boundin... branch activity View project dashboard

Pierre-Gilles commented 5 months ago

@all-contributors please add @GziAzman for code

allcontributors[bot] commented 5 months ago

@Pierre-Gilles

I've put up a pull request to add @GziAzman! :tada: