GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.57k stars 278 forks source link

add icon to music feature types #2051

Closed William-De71 closed 4 months ago

William-De71 commented 5 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

image

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.38%. Comparing base (bcdc5ee) to head (cac32c5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2051 +/- ## ======================================= Coverage 98.38% 98.38% ======================================= Files 844 844 Lines 13753 13753 ======================================= Hits 13531 13531 Misses 222 222 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 5 months ago

Job #2458: Bundle Size — 10.04MiB (~+0.01%).

cac32c5(current) vs bcdc5ee master#2455(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
Job #2458
     Baseline
Job #2455
Regression  Initial JS 5.38MiB(+0.01%) 5.38MiB
No change  Initial CSS 303.21KiB 303.21KiB
Change  Cache Invalidation 53.44% 0%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1459 1459
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.78% 0.78%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  Change 1 change Regression 1 regression
|            |       Current
[Job #2458](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2458-1wJS54e43Z9h6WuhTeEy?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #2455](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2455-GpSdW17KtmCTDkHOcpjk?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2458-1wJS54e43Z9h6WuhTeEy/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.14MiB` (`+0.01%`) | `7.14MiB` | | Not changed  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2458-1wJS54e43Z9h6WuhTeEy/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.46MiB` | `2.46MiB` | | Not changed  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2458-1wJS54e43Z9h6WuhTeEy/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.71KiB` | `319.71KiB` | | Not changed  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2458-1wJS54e43Z9h6WuhTeEy/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | Not changed  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2458-1wJS54e43Z9h6WuhTeEy/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.53KiB` | `17.53KiB` | | Not changed  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2458-1wJS54e43Z9h6WuhTeEy/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

View job #2458 reportView William-De71:music-feature-icon branch activityView project dashboard