search

GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.57k stars 278 forks source link

Fix #2000 : Should not delete tags when patching scene without tags #2055

Closed Pierre-Gilles closed 4 months ago

Pierre-Gilles commented 4 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix https://github.com/GladysAssistant/Gladys/issues/2000

cloudflare-pages[bot] commented 4 months ago

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7634ce5
Status: ✅  Deploy successful!
Preview URL: https://b586233a.gladys-plus.pages.dev
Branch Preview URL: https://fix-tags-bug.gladys-plus.pages.dev

View logs

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.38%. Comparing base (1154325) to head (7634ce5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2055 +/- ## ======================================= Coverage 98.38% 98.38% ======================================= Files 844 844 Lines 13760 13760 ======================================= Hits 13538 13538 Misses 222 222 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 4 months ago

Job #2467: Bundle Size — 10.04MiB (0%).

7634ce5(current) vs 1154325 master#2466(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #2467		      Baseline
Job #2466
No change  Initial JS 5.38MiB 5.38MiB
No change  Initial CSS 303.21KiB 303.21KiB
Change  Cache Invalidation 0% 53.44%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1459 1459
No change  Duplicate Modules 20 20
No change  Duplicate Code 0.78% 0.78%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  no changes
|            |       Current
[Job #2467](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2467-pB6NdAUmnTB7AgLUzgZt?utm_source=github&utm_medium=pr-report "View job report") |      Baseline
[Job #2466](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2466-6usM8FaI8MXPLFpEEmNA?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Not changed  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2467-pB6NdAUmnTB7AgLUzgZt/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.14MiB` | `7.14MiB` | | Not changed  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2467-pB6NdAUmnTB7AgLUzgZt/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.46MiB` | `2.46MiB` | | Not changed  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2467-pB6NdAUmnTB7AgLUzgZt/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.71KiB` | `319.71KiB` | | Not changed  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2467-pB6NdAUmnTB7AgLUzgZt/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | Not changed  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2467-pB6NdAUmnTB7AgLUzgZt/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.53KiB` | `17.53KiB` | | Not changed  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2467-pB6NdAUmnTB7AgLUzgZt/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

View job #2467 report View fix-tags-bug branch activity View project dashboard