Pierre-Gilles commented 3 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

[x] If your changes affects code, did your write the tests?
[x] Are tests passing? (npm test on both front/server)
[x] Is the linter passing? (npm run eslint on both front/server)
[x] Did you run prettier? (npm run prettier on both front/server)
[ ] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Fix bug on Aqara motion sensor ( https://community.gladysassistant.com/t/conflict-lors-de-lajout-dun-device-z2m/6736/21 )

cloudflare-pages[bot] commented 3 months ago

Deploying gladys-plus with Cloudflare Pages

Latest commit:	`825ffb1`
Status:	✅ Deploy successful!
Preview URL:	https://efefc352.gladys-plus.pages.dev
Branch Preview URL:	https://fix-zigbee2mqtt-aqara.gladys-plus.pages.dev

View logs

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.38%. Comparing base (2251726) to head (825ffb1).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2057 +/- ## ======================================= Coverage 98.38% 98.38% ======================================= Files 844 844 Lines 13760 13766 +6 ======================================= + Hits 13538 13544 +6 Misses 222 222 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 3 months ago

Job #2469: Bundle Size — 10.04MiB (0%).

825ffb1(current) vs 2251726 master#2468(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics no changes

	Current Job #2469	Baseline Job #2468
Initial JS	`5.38MiB`	`5.38MiB`
Initial CSS	`303.21KiB`	`303.21KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`51`	`51`
Assets	`170`	`170`
Modules	`1459`	`1459`
Duplicate Modules	`20`	`20`
Duplicate Code	`0.78%`	`0.78%`
Packages	`124`	`124`
Duplicate Packages	`3`	`3`

Bundle size by type no changes

| | Current
[Job #2469](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2469-7U1OzvVJKCbYnrJHe7el?utm_source=github&utm_medium=pr-report "View job report") | Baseline
[Job #2468](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2468-lj5sh3mngbM1QAG9coeN?utm_source=github&utm_medium=pr-report "View baseline job report") | |:--|--:|--:| | Not changed

[JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2469-7U1OzvVJKCbYnrJHe7el/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.14MiB` | `7.14MiB` | | Not changed

[IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2469-7U1OzvVJKCbYnrJHe7el/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.46MiB` | `2.46MiB` | | Not changed

[CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2469-7U1OzvVJKCbYnrJHe7el/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.71KiB` | `319.71KiB` | | Not changed

[Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2469-7U1OzvVJKCbYnrJHe7el/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | Not changed

[Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2469-7U1OzvVJKCbYnrJHe7el/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.53KiB` | `17.53KiB` | | Not changed

[HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2469-7U1OzvVJKCbYnrJHe7el/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

View job #2469 report View fix-zigbee2mqtt-aqara branch activity View project dashboard

GladysAssistant / Gladys

Zigbee2mqtt : Remove duplicate features in getDiscoveredDevices to fix bug on Aqara motion sensor #2057

Pull Request check-list

Description of change

Deploying gladys-plus with Cloudflare Pages

Codecov Report

Job #2469: Bundle Size — 10.04MiB (0%).