Closed sescandell closed 3 months ago
3a75f91(current) vs 88e10e2 master#2542(baseline)
[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages
Bundle metrics
![]()
2 changes
![]()
1 regression
Current #2546 |
Baseline #2542 |
|
---|---|---|
5.45MiB (+0.09% ) |
5.44MiB |
|
302.96KiB |
302.96KiB |
|
53.65% |
53.58% |
|
51 |
51 |
|
170 |
170 |
|
1479 |
1479 |
|
21 |
21 |
|
0.82% |
0.82% |
|
124 |
124 |
|
3 |
3 |
1 change
1 regression
Bundle analysis report Branch sescandell:zwaveMultilevelSwitch Project dashboard
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.40%. Comparing base (
a6569de
) to head (3a75f91
). Report is 8 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for checking the forum, I've added some comments about this PR.
https://community.gladysassistant.com/t/evolution-du-service-z-wave-js-ui/8692/38
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server) ~- [ ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations
on front)~front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
This PR is to manage multilevel switch. These devices could have multiple purpose. It handles specific curtains and standard dimmers.
Dashboard![image](https://github.com/GladysAssistant/Gladys/assets/1559970/5dec50ad-b2dd-4b14-a001-02921599483e)
Intégration![image](https://github.com/GladysAssistant/Gladys/assets/1559970/59536b36-8fac-4b8a-baff-83d32926e581)
Tested on real life devices with Fibaro Walli Roller Shutter & Fibaro Walli Dimmer
This update introduces a new way to add multiple features from the same zWave property. This is usefull for example to manage, with the same property (currentValue) two different features: a Dimmer and a Binary state. For Dimmers, turning the device ON executes a restorePrevious state (cloning real button behavior).