GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.55k stars 278 forks source link

Feat blink light from switch device #2064

Closed cicoub13 closed 3 months ago

cicoub13 commented 3 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add ability to use switch (binary) devices in the action Blink Lights

Functional test in real life ✅ (done by @Gboulvin)

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.39%. Comparing base (f90b143) to head (1abd427).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2064 +/- ## ======================================= Coverage 98.39% 98.39% ======================================= Files 847 847 Lines 13820 13822 +2 ======================================= + Hits 13598 13600 +2 Misses 222 222 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 3 months ago

#2519 Bundle Size — 10.08MiB (~+0.01%).

1abd427(current) vs f90b143 master#2517(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change Regression 1 regression
                 Current
#2519
     Baseline
#2517
Regression  Initial JS 5.4MiB(~+0.01%) 5.4MiB
No change  Initial CSS 303.21KiB 303.21KiB
No change  Cache Invalidation 53.45% 53.45%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1465 1465
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  Change 1 change Regression 1 regression
|            |       Current
[#2519](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2519-19XSE1MZ2OmY5thlhp7W?utm_source=github&utm_medium=pr-report "View bundle analysis report") |      Baseline
[#2517](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2517-Y9jwdvkKSx7I1PdLkFyr?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2519-19XSE1MZ2OmY5thlhp7W/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.18MiB` (`~+0.01%`) | `7.18MiB` | | No change  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2519-19XSE1MZ2OmY5thlhp7W/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.46MiB` | `2.46MiB` | | No change  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2519-19XSE1MZ2OmY5thlhp7W/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.99KiB` | `319.99KiB` | | No change  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2519-19XSE1MZ2OmY5thlhp7W/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | No change  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2519-19XSE1MZ2OmY5thlhp7W/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.53KiB` | `17.53KiB` | | No change  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2519-19XSE1MZ2OmY5thlhp7W/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

Bundle analysis reportBranch cicoub13:feat-blink-electric-plu...Project dashboard