GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.55k stars 278 forks source link

Zigbee2mqtt : Keep keep_history when updating feature + fix update from devices with duplicate features #2072

Closed Pierre-Gilles closed 3 months ago

Pierre-Gilles commented 3 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

Description of change

Fix https://github.com/GladysAssistant/Gladys/issues/2069 & https://github.com/GladysAssistant/Gladys/issues/2060

cloudflare-pages[bot] commented 3 months ago

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 417b587
Status: ✅  Deploy successful!
Preview URL: https://e438de69.gladys-plus.pages.dev
Branch Preview URL: https://zigbee2mqtt-fix-update-bug.gladys-plus.pages.dev

View logs

relativeci[bot] commented 3 months ago

#2539 Bundle Size — 10.11MiB (0%).

417b587(current) vs cd825ab master#2536(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2539
     Baseline
#2536
No change  Initial JS 5.43MiB 5.43MiB
No change  Initial CSS 302.96KiB 302.96KiB
Change  Cache Invalidation 0% 63.03%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1478 1478
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  no changes
|            |       Current
[#2539](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2539-Yi3LFx2bmrLhfXCDx8jA?utm_source=github&utm_medium=pr-report "View bundle analysis report") |      Baseline
[#2536](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2536-Z70fWNdn6VEczUt5XhYp?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | No change  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2539-Yi3LFx2bmrLhfXCDx8jA/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.21MiB` | `7.21MiB` | | No change  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2539-Yi3LFx2bmrLhfXCDx8jA/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.46MiB` | `2.46MiB` | | No change  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2539-Yi3LFx2bmrLhfXCDx8jA/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.75KiB` | `319.75KiB` | | No change  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2539-Yi3LFx2bmrLhfXCDx8jA/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | No change  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2539-Yi3LFx2bmrLhfXCDx8jA/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.53KiB` | `17.53KiB` | | No change  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2539-Yi3LFx2bmrLhfXCDx8jA/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

Bundle analysis reportBranch zigbee2mqtt-fix-update-bugProject dashboard

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.38%. Comparing base (cd825ab) to head (417b587).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2072 +/- ## ======================================= Coverage 98.38% 98.38% ======================================= Files 850 850 Lines 13907 13909 +2 ======================================= + Hits 13683 13685 +2 Misses 224 224 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.