GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.55k stars 278 forks source link

Sonos.playNotification : Increase timout + add delayMs + more logs to getTTSApiUrl #2089

Closed Pierre-Gilles closed 2 months ago

Pierre-Gilles commented 2 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

Description of change

Try to fix issues on Sonos.playNotification feature

cloudflare-pages[bot] commented 2 months ago

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6bb7bf0
Status: ✅  Deploy successful!
Preview URL: https://e30c7b88.gladys-plus.pages.dev
Branch Preview URL: https://sonos-play-notification-impr.gladys-plus.pages.dev

View logs

relativeci[bot] commented 2 months ago

#2603 Bundle Size — 10.14MiB (0%).

6bb7bf0(current) vs 551d511 master#2601(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2603
     Baseline
#2601
No change  Initial JS 5.46MiB 5.46MiB
No change  Initial CSS 302.96KiB 302.96KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 51 51
No change  Assets 170 170
No change  Modules 1480 1480
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  no changes
|            |       Current
[#2603](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2603-QTqMy3hS89xy9WvJMY5c?utm_source=github&utm_medium=pr-report "View bundle analysis report") |      Baseline
[#2601](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2601-xaoNNMJFtoEYA2GEUTlW?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | No change  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2603-QTqMy3hS89xy9WvJMY5c/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.24MiB` | `7.24MiB` | | No change  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2603-QTqMy3hS89xy9WvJMY5c/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.46MiB` | `2.46MiB` | | No change  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2603-QTqMy3hS89xy9WvJMY5c/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.75KiB` | `319.75KiB` | | No change  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2603-QTqMy3hS89xy9WvJMY5c/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | No change  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2603-QTqMy3hS89xy9WvJMY5c/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.53KiB` | `17.53KiB` | | No change  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2603-QTqMy3hS89xy9WvJMY5c/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

Bundle analysis reportBranch sonos-play-notification-improvem...Project dashboard

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.40%. Comparing base (551d511) to head (6bb7bf0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2089 +/- ## ======================================= Coverage 98.40% 98.40% ======================================= Files 858 858 Lines 14081 14081 ======================================= Hits 13857 13857 Misses 224 224 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.