GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.55k stars 278 forks source link

[WIP] Add charts-history feature #2091

Closed Terdious closed 2 months ago

Terdious commented 2 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Please provide a description of the change here. It's always best with screenshots, so don't hesitate to add some!

relativeci[bot] commented 2 months ago

#2594 Bundle Size — 12.07MiB (+19.12%).

cc73a5b(current) vs 09a7987 master#2576(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

[!WARNING] Bundle introduced 2 new packages: xlsx-js-style, sweetalert2 – View changed packages

Bundle metrics  Change 9 changes Regression 4 regressions
                 Current
#2594
     Baseline
#2576
Regression  Initial JS 7.38MiB(+35.22%) 5.46MiB
Regression  Initial CSS 305.06KiB(+0.69%) 302.96KiB
Change  Cache Invalidation 70.6% 63.14%
Change  Chunks 53(+3.92%) 51
Change  Assets 172(+1.18%) 170
Change  Modules 1506(+1.76%) 1480
Regression  Duplicate Modules 22(+4.76%) 21
Change  Duplicate Code 0.75%(-8.54%) 0.82%
Regression  Packages 126(+1.61%) 124
No change  Duplicate Packages 3 3

Bundle size by type  Change 3 changes Regression 3 regressions
|            |       Current
[#2594](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2594-pPxvTa5HM4fLeXFS5ry8?utm_source=github&utm_medium=pr-report "View bundle analysis report") |      Baseline
[#2576](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2576-XzFOw5qxGQBieSZSEbjB?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2594-pPxvTa5HM4fLeXFS5ry8/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `9.17MiB` (`+26.75%`) | `7.24MiB` | | No change  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2594-pPxvTa5HM4fLeXFS5ry8/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.46MiB` | `2.46MiB` | | Regression  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2594-pPxvTa5HM4fLeXFS5ry8/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `321.85KiB` (`+0.66%`) | `319.75KiB` | | No change  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2594-pPxvTa5HM4fLeXFS5ry8/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | Regression  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2594-pPxvTa5HM4fLeXFS5ry8/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.86KiB` (`+1.91%`) | `17.53KiB` | | No change  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2594-pPxvTa5HM4fLeXFS5ry8/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

Bundle analysis reportBranch Terdious:add-view-chartsProject dashboard

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 35.48387% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 98.12%. Comparing base (09a7987) to head (a5a2b64).

:exclamation: Current head a5a2b64 differs from pull request most recent head cc73a5b

Please upload reports for the commit cc73a5b to get more accurate results.

Files Patch % Lines
...erver/lib/device/device.getDeviceFeaturesStates.js 22.85% 27 Missing :warning:
...r/lib/device/device.getDeviceFeaturesAggregates.js 37.50% 10 Missing :warning:
.../lib/device/device.getDeviceFeaturesStatesMulti.js 50.00% 2 Missing :warning:
server/api/controllers/device.controller.js 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2091 +/- ## ========================================== - Coverage 98.40% 98.12% -0.29% ========================================== Files 858 860 +2 Lines 14081 14141 +60 ========================================== + Hits 13857 13876 +19 - Misses 224 265 +41 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Terdious commented 2 months ago

Hello @Pierre-Gilles, I wanted to mount a test image but the linux/amd64 version does not work on "Docker magic !", I can't figure out why? Do you have an idea? No problem with linux/arm64 (v8)