Open Terdious opened 2 months ago
a27ae0b(current) vs e83d529 master#2649(baseline)
[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages
Bundle metrics
![]()
3 changes
![]()
1 regression
Current #2661 |
Baseline #2649 |
|
---|---|---|
5.5MiB (+0.25% ) |
5.49MiB |
|
303.12KiB |
303.12KiB |
|
53.79% |
53.79% |
|
51 |
51 |
|
171 |
171 |
|
1491 (+0.07% ) |
1490 |
|
21 |
21 |
|
0.81% (-1.22% ) |
0.82% |
|
124 |
124 |
|
3 |
3 |
1 change
1 regression
Bundle analysis report Branch Terdious:add-binary-chart Project dashboard
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.41%. Comparing base (
e83d529
) to head (a27ae0b
). Report is 3 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
- Text is inside the "bar" :
I'm sorry but I tried to reproduce and despite zooming in / out changing resolution, etc. I never managed to get your result. On the other hand, before my previous modification I had the same problem, but I corrected it before your review
- I get a freeze when saving the dashboard with a binary chart on a power plug
I added a console.log(deviceFeature);
because I can't seem to reproduce. I tested all types of binary, tasmota and mqtt (including a power plug). And I have no problems with the units (everything is 'null'). Could you send me the logs?
- If I select a binary device, then unselect it, then select a non-binary device, I get a weird state where the chart type is unknown
Corrected
- When I'm using Gladys in English, the text inside the popup is in french
Corrected
- On mobile, the popup is outside of the screen
Corrected. Display top left box
@Terdious Thanks for the fixes!
Here is the payload that causes the freeze:
{"id":"e499dd5e-6482-4cbd-a73e-159d53c9b402","name":"Graph","selector":"graph","type":"main","visibility":"private","user_id":"275faa00-8a9c-4747-8fbe-417ddb966b16","created_at":"2024-06-10T08:20:20.784Z","updated_at":"2024-06-17T11:30:17.089Z","boxes":[[{"type":"chart","device_features":["mqtt-priseonoff"],"units":[null],"title":"Binaire","chart_type":"","interval":"last-day","display_axes":true}],[],[]]}
The response is 422 :
{
"status": 422,
"code": "UNPROCESSABLE_ENTITY",
"properties": [
{
"message": "\"[0][0].chart_type\" is not allowed to be empty",
"attribute": "boxes",
"value": [
[
{
"type": "chart",
"device_features": [
"mqtt-priseonoff"
],
"units": [
null
],
"title": "Binaire",
"chart_type": "",
"interval": "last-day",
"display_axes": true
}
],
[],
[]
],
"type": "Validation error"
}
]
}
It's just because I didn't select the "chart type" ^^ It's maybe not related to this PR, but I wonder if we could make a fix to avoid freezing in this situation...
I have another feedback, now the date in english is not correct:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front)npm run eslint
on both front)npm run prettier
on both front)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Taken from the original PR: #Binary graph #1948 Thanks to @callemand for all the work done