GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.55k stars 278 forks source link

Add column functionality to EditDashboard component #2097

Open Terdious opened 2 months ago

Terdious commented 2 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Adding the deletion or addition of columns to the dashboard

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.41%. Comparing base (e83d529) to head (786a4a9). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2097 +/- ## ======================================= Coverage 98.41% 98.41% ======================================= Files 865 865 Lines 14169 14169 ======================================= Hits 13945 13945 Misses 224 224 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 2 months ago

#2655 Bundle Size — 10.18MiB (+0.06%).

786a4a9(current) vs e83d529 master#2649(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 2 regressions
                 Current
#2655
     Baseline
#2649
Regression  Initial JS 5.49MiB(+0.09%) 5.49MiB
Regression  Initial CSS 304.37KiB(+0.41%) 303.12KiB
Change  Cache Invalidation 66.09% 53.79%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1490 1490
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  Change 2 changes Regression 2 regressions
|            |       Current
[#2655](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2655-Z40TRCL2Ob9l7gBxz1hc?utm_source=github&utm_medium=pr-report "View bundle analysis report") |      Baseline
[#2649](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2649-7NuzpnuSq3dwLB70Mkt3?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2655-Z40TRCL2Ob9l7gBxz1hc/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.27MiB` (`+0.07%`) | `7.27MiB` | | No change  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2655-Z40TRCL2Ob9l7gBxz1hc/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.48MiB` | `2.48MiB` | | Regression  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2655-Z40TRCL2Ob9l7gBxz1hc/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `321.16KiB` (`+0.39%`) | `319.91KiB` | | No change  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2655-Z40TRCL2Ob9l7gBxz1hc/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | No change  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2655-Z40TRCL2Ob9l7gBxz1hc/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.62KiB` | `17.62KiB` | | No change  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2655-Z40TRCL2Ob9l7gBxz1hc/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

Bundle analysis reportBranch Terdious:add-choice-number-colum...Project dashboard

stale[bot] commented 1 day ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.