search

GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.55k stars 278 forks source link

Fix z-index issue on device.setValue scene action #2100

Closed Pierre-Gilles closed 2 months ago

Pierre-Gilles commented 2 months ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

Description of change

Fix https://github.com/GladysAssistant/Gladys/issues/2098 & https://github.com/GladysAssistant/Gladys/issues/2067

cloudflare-pages[bot] commented 2 months ago

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: b0774dd
Status: ✅  Deploy successful!
Preview URL: https://4e93b4a8.gladys-plus.pages.dev
Branch Preview URL: https://fix-z-index-issue-on-device.gladys-plus.pages.dev

View logs

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.41%. Comparing base (4405399) to head (b0774dd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2100 +/- ## ======================================= Coverage 98.41% 98.41% ======================================= Files 865 865 Lines 14162 14162 ======================================= Hits 13938 13938 Misses 224 224 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 2 months ago

#2633 Bundle Size — 10.18MiB (+0.01%).

b0774dd(current) vs 4405399 master#2630(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2633		      Baseline
#2630
Regression  Initial JS 5.49MiB(+0.02%) 5.48MiB
No change  Initial CSS 303.12KiB 303.12KiB
Change  Cache Invalidation 53.79% 0%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1490 1490
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  Change 1 change Regression 1 regression
|            |       Current
[#2633](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2633-XPDZTj0r2XDpfYoLEBm8?utm_source=github&utm_medium=pr-report "View bundle analysis report") |      Baseline
[#2630](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2630-DwdeqrkMcTOLMg1CRTnk?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2633-XPDZTj0r2XDpfYoLEBm8/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.27MiB` (`+0.02%`) | `7.27MiB` | | No change  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2633-XPDZTj0r2XDpfYoLEBm8/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.48MiB` | `2.48MiB` | | No change  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2633-XPDZTj0r2XDpfYoLEBm8/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.91KiB` | `319.91KiB` | | No change  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2633-XPDZTj0r2XDpfYoLEBm8/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | No change  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2633-XPDZTj0r2XDpfYoLEBm8/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.62KiB` | `17.62KiB` | | No change  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2633-XPDZTj0r2XDpfYoLEBm8/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

Bundle analysis report Branch fix-z-index-issue-on-device-set-... Project dashboard