GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.55k stars 278 forks source link

Refactor Edit Box Devices component to improve device options filtering #2101

Closed Terdious closed 2 months ago

Terdious commented 2 months ago

…ring

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

- [ ] If your changes affects code, did your write the tests?

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Like the device selection field in the box charts, addition of a filter in the selection field of the "Devices" box allowing all devices already selected to be removed from the list image image

relativeci[bot] commented 2 months ago

#2647 Bundle Size — 10.18MiB (~+0.01%).

83db9b7(current) vs d450277 master#2645(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2647
     Baseline
#2645
Regression  Initial JS 5.49MiB(~+0.01%) 5.49MiB
No change  Initial CSS 303.12KiB 303.12KiB
Change  Cache Invalidation 53.79% 0%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1490 1490
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.82% 0.82%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  Change 1 change Regression 1 regression
|            |       Current
[#2647](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2647-zWycqeosrT4gesd1fOkX?utm_source=github&utm_medium=pr-report "View bundle analysis report") |      Baseline
[#2645](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2645-h3mlL3qOnAs6TkuUp0cs?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2647-zWycqeosrT4gesd1fOkX/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.27MiB` (`~+0.01%`) | `7.27MiB` | | No change  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2647-zWycqeosrT4gesd1fOkX/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.48MiB` | `2.48MiB` | | No change  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2647-zWycqeosrT4gesd1fOkX/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `319.91KiB` | `319.91KiB` | | No change  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2647-zWycqeosrT4gesd1fOkX/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | No change  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2647-zWycqeosrT4gesd1fOkX/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.62KiB` | `17.62KiB` | | No change  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2647-zWycqeosrT4gesd1fOkX/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

Bundle analysis reportBranch Terdious:edit-dashboard-refine-b...Project dashboard

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.41%. Comparing base (d450277) to head (83db9b7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2101 +/- ## ======================================= Coverage 98.41% 98.41% ======================================= Files 865 865 Lines 14169 14169 ======================================= Hits 13945 13945 Misses 224 224 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.