Closed Terdious closed 2 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.48%. Comparing base (
2b8e274
) to head (f0aaeb5
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
f0aaeb5(current) vs 2b8e274 master#2753(baseline)
[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages
Bundle metrics
2 changes
1 regression
Current #2754 |
Baseline #2753 |
|
---|---|---|
Initial JS | 5.54MiB (~+0.01% ) |
5.54MiB |
Initial CSS | 304.63KiB |
304.63KiB |
Cache Invalidation | 54.02% |
0% |
Chunks | 51 |
51 |
Assets | 171 |
171 |
Modules | 1492 |
1492 |
Duplicate Modules | 21 |
21 |
Duplicate Code | 0.83% |
0.83% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
1 change
1 regression
Bundle analysis report Branch Terdious:improvement-height-char... Project dashboard
Generated by RelativeCI Documentation Report issue
Do you have example where the change is really impressive (before/after)?
…d on additional features
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
If your changes affects code, did your write the tests?Are tests passing? (npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)If you are adding a new features/services, did you run integration comparator? (npm run compare-translations
on front)Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.Did you add fake requests data for the demo mode (front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Small PR to increase the height of the charts depending on the number of features selected. Currently the curve is squashed to make room for the legend and contain the size of the box.