GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.67k stars 282 forks source link

refactor: Update ApexChartComponent to dynamically adjust height base… #2117

Closed Terdious closed 2 weeks ago

Terdious commented 1 month ago

…d on additional features

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Small PR to increase the height of the charts depending on the number of features selected. Currently the curve is squashed to make room for the legend and contain the size of the box.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.48%. Comparing base (2b8e274) to head (f0aaeb5). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2117 +/- ## ======================================= Coverage 98.48% 98.48% ======================================= Files 867 867 Lines 14187 14187 ======================================= Hits 13972 13972 Misses 215 215 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 1 month ago

#2754 Bundle Size — 10.24MiB (~+0.01%).

f0aaeb5(current) vs 2b8e274 master#2753(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#2754
     Baseline
#2753
Regression  Initial JS 5.54MiB(~+0.01%) 5.54MiB
No change  Initial CSS 304.63KiB 304.63KiB
Change  Cache Invalidation 54.02% 0%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1492 1492
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  Change 1 change Regression 1 regression
|            |       Current
[#2754](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2754-M7OWbnGU9HsBbbCi3dDF?utm_source=github&utm_medium=pr-report "View bundle analysis report") |      Baseline
[#2753](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2753-X4Ce4HucRVOXLKzJJl3q?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | Regression  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2754-M7OWbnGU9HsBbbCi3dDF/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.32MiB` (`~+0.01%`) | `7.32MiB` | | No change  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2754-M7OWbnGU9HsBbbCi3dDF/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.48MiB` | `2.48MiB` | | No change  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2754-M7OWbnGU9HsBbbCi3dDF/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `321.42KiB` | `321.42KiB` | | No change  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2754-M7OWbnGU9HsBbbCi3dDF/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | No change  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2754-M7OWbnGU9HsBbbCi3dDF/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.62KiB` | `17.62KiB` | | No change  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2754-M7OWbnGU9HsBbbCi3dDF/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

Bundle analysis reportBranch Terdious:improvement-height-char...Project dashboard


Generated by RelativeCIDocumentationReport issue

Terdious commented 2 weeks ago

Do you have example where the change is really impressive (before/after)?