Gladys Plus: Increase ackTimeout to 60s

Pierre-Gilles commented 2 weeks ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

[x] If your changes affects code, did your write the tests?
[x] Are tests passing? (npm test on both front/server)
[x] Is the linter passing? (npm run eslint on both front/server)
[x] Did you run prettier? (npm run prettier on both front/server)
[x] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
[x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
[x] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
[x] If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
[x] Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Increase ackTimeout to 60s because some instances were disconnecting because of the low timeout

cloudflare-workers-and-pages[bot] commented 2 weeks ago

Deploying gladys-plus with Cloudflare Pages

Latest commit:	`829557a`
Status:	✅ Deploy successful!
Preview URL:	https://7162538b.gladys-plus.pages.dev
Branch Preview URL:	https://increase-ack-timeout-gladys.gladys-plus.pages.dev

View logs

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.48%. Comparing base (e0e2d37) to head (829557a). Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #2128 +/- ## ======================================= Coverage 98.48% 98.48% ======================================= Files 867 867 Lines 14187 14187 ======================================= Hits 13972 13972 Misses 215 215 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

relativeci[bot] commented 2 weeks ago

#2765 Bundle Size — 10.24MiB (0%).

829557a(current) vs e0e2d37 master#2763(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics no changes

	Current #2765	Baseline #2763
Initial JS	`5.54MiB`	`5.54MiB`
Initial CSS	`304.63KiB`	`304.63KiB`
Cache Invalidation	`54.02%`	`54.02%`
Chunks	`51`	`51`
Assets	`171`	`171`
Modules	`1492`	`1492`
Duplicate Modules	`21`	`21`
Duplicate Code	`0.83%`	`0.83%`
Packages	`124`	`124`
Duplicate Packages	`3`	`3`

Bundle size by type no changes

| | Current
[#2765](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2765-Yz2znOzXXFU2IPgVRugT?utm_source=github&utm_medium=pr-report "View bundle analysis report") | Baseline
[#2763](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2763-pMxrJgtOg0vjDO9qTwb0?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | No change

[JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2765-Yz2znOzXXFU2IPgVRugT/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.32MiB` | `7.32MiB` | | No change

[IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2765-Yz2znOzXXFU2IPgVRugT/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.48MiB` | `2.48MiB` | | No change

[CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2765-Yz2znOzXXFU2IPgVRugT/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `321.42KiB` | `321.42KiB` | | No change

[Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2765-Yz2znOzXXFU2IPgVRugT/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | No change

[Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2765-Yz2znOzXXFU2IPgVRugT/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.62KiB` | `17.62KiB` | | No change

[HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2765-Yz2znOzXXFU2IPgVRugT/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

Bundle analysis report Branch increase-ack-timeout-gladys-plus Project dashboard

^{Generated by RelativeCI Documentation Report issue}

GladysAssistant / Gladys