GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.67k stars 282 forks source link

Handle multi service device in HomeKit #2139

Closed bertrandda closed 1 day ago

bertrandda commented 1 week ago

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add correct control of multiple same service device (ex: multiprise contains multiple switch)

relativeci[bot] commented 1 week ago

#2788 Bundle Size — 10.23MiB (0%).

9202640(current) vs a000b56 master#2786(baseline)

[!WARNING] Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2788
     Baseline
#2786
No change  Initial JS 5.53MiB 5.53MiB
No change  Initial CSS 304.68KiB 304.68KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 51 51
No change  Assets 171 171
No change  Modules 1491 1491
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3

Bundle size by type  no changes
|            |       Current
[#2788](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2788-7w2Q4oDeHucdnjZxd5Xu?utm_source=github&utm_medium=pr-report "View bundle analysis report") |      Baseline
[#2786](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2786-OocYA4KyqprUdGKUHKWM?utm_source=github&utm_medium=pr-report "View baseline bundle analysis report") | |:--|--:|--:| | No change  [JS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2788-7w2Q4oDeHucdnjZxd5Xu/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-1_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View JS assets") | `7.32MiB` | `7.32MiB` | | No change  [IMG](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2788-7w2Q4oDeHucdnjZxd5Xu/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-1_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View IMG assets") | `2.48MiB` | `2.48MiB` | | No change  [CSS](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2788-7w2Q4oDeHucdnjZxd5Xu/assets?ba=%7B%22filters%22%3A%22ft.CSS-1_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-0%22%7D "View CSS assets") | `321.47KiB` | `321.47KiB` | | No change  [Fonts](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2788-7w2Q4oDeHucdnjZxd5Xu/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-1_ft.HTML-0_ft.OTHER-0%22%7D "View Fonts assets") | `93.55KiB` | `93.55KiB` | | No change  [Other](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2788-7w2Q4oDeHucdnjZxd5Xu/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-0_ft.OTHER-1%22%7D "View Other assets") | `17.62KiB` | `17.62KiB` | | No change  [HTML](https://app.relative-ci.com/projects/PUROh8FAVkDKmpUrqr4u/jobs/2788-7w2Q4oDeHucdnjZxd5Xu/assets?ba=%7B%22filters%22%3A%22ft.CSS-0_ft.JS-0_ft.IMG-0_ft.MEDIA-0_ft.FONT-0_ft.HTML-1_ft.OTHER-0%22%7D "View HTML assets") | `13.58KiB` | `13.58KiB` |

Bundle analysis reportBranch bertrandda:fix/homekit-multi-ser...Project dashboard


Generated by RelativeCIDocumentationReport issue

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.48%. Comparing base (a000b56) to head (9202640). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2139 +/- ## ======================================= Coverage 98.48% 98.48% ======================================= Files 867 867 Lines 14191 14199 +8 ======================================= + Hits 13976 13984 +8 Misses 215 215 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.