GladysAssistant / Gladys

A privacy-first, open-source home assistant
https://gladysassistant.com
Apache License 2.0
2.67k stars 282 forks source link

Add a device category/type for rolling shutters #934

Closed Pierre-Gilles closed 3 years ago

Pierre-Gilles commented 3 years ago

Functional specs

It should be able to be open/close with different levels:

To do

@atrovato any opinion on that for the MQTT part ? It was asked by a MQTT user

atrovato commented 3 years ago

Not sure to understand the question, but I think a int 0 - 100 a percent is doing it well. Let me check on Tasmota service if I already defined it.

Dashboard display is another question.

Pierre-Gilles commented 3 years ago

I'm talking about user experience ! It doesn't solve the problem, how do you know on the UI side which percentage the device supports?

I had a feedback of a user which had shutters which only supports 0, 50 et 100%.

So a slider doesn't work, it needs to be like 3 buttons [closed] [50%] [open]

But this is not generic, because as I said another users can have a rolling shutters with another configuration.

The question is how to make this easy to specify for the user

Pierre-Gilles commented 3 years ago

I'm thinking about it 😃

Pierre-Gilles commented 3 years ago

When thinking about it, it's maybe more a general question : how do we handle devices with specific functions ?

For example devices with multi-states button ? (0, 1, 2)

How do we define them in an "open" services like MQTT ?

atrovato commented 3 years ago

What about a [ up | stop | down ] swith?

Pierre-Gilles commented 3 years ago

It's not the question ! How do you know that the roller shutter supports up / stop / down ?

The question is : Right now in Gladys, we only handle a simple type in the UI : On/Off.

How do we handle multi-state types ?

atrovato commented 3 years ago

I think we can have a look to other existing platforms to handle new device types

https://developers.google.com/assistant/smarthome/guides/shutter

https://smartthings.developer.samsung.com/docs/api-ref/capabilities.html

For Google, shutter is a percent and a direction, so an integer 0 - 100 can do the job for us. With a new device feature SHUTTER / OPEN (?).

So a simple setValue with int on this feature will do the job. But UI is another topic.

Pierre-Gilles commented 3 years ago

Let's talk about it here : https://community.gladysassistant.com/t/gestion-des-volets-roulants/5693

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Pierre-Gilles commented 3 years ago

Ok closing this as it's a feature request, and we were already talking about it on the forum.