Glagan / SyncDex

Automatically sync what you read on MangaDex across many services like MyAnimeList, Anilist, Kitsu and more.
Mozilla Public License 2.0
46 stars 0 forks source link

[REQUEST] Sync to mangadex reading progress #34

Closed Jerrk closed 3 years ago

Jerrk commented 3 years ago

Is your feature request related to a problem? Please describe. The mangadex reading progress will only update if you change it manually, start from the beginning, or read the next chapter to the count. Say i have read 30 chapters of a manga on mangadex so the count is 30, i then read 40 chapters on a scanlators site, when i then come back to read chapter 71 on mangadex the reading progress will not update and i would have to change it manually.

Describe the solution you'd like I'm not sure if this would be considered as adding another service, but i would like for the tracking count to be shown in the mangadex reading progress as well if possible.

Additional context firefox_Kt2KQN1RSW

Glagan commented 3 years ago

Hum, adding this as a service might make some things simple, but I'm not sure (code wise).

I don't know how to avoid excessive requests thought, since I can't access this value outside of the Title page, so in all other pages that can update your list I would always send a request to update it, but in the end it's the same for all other Services.

I'll look at it, and it will be linked to the other MangaDex related options, so Update MD list will update status, score and progress.
Maybe I will add another option to avoid updating it since it's extra requests and personally I don't use the MangaDex progress at all.

Glagan commented 3 years ago

Sorry for the delay, I added an option since 0.2.4, disabled by default, in the MangaDex category.

image

Progress is only updated one way for now, meaning that the progress is only updated but never read to update SyncDex. I might add that in another release.

Zw012d commented 3 years ago

It has a bug in current version. ex. Mangadex last reading progress is 10.1 and next chapter is 11 then after reading the reading progress in mangadex will be 11.1 instead of 11.

Glagan commented 3 years ago

Do you have a link for the Title the bug happened ?

Zw012d commented 3 years ago

It occurs in every manga with decimal system. Fixed by manually Set Latest but that will cause history disappear bug.

Steps: Ex. -1 https://mangadex.org/title/31792/mieruko-chan 1) Read Chapter 9 Screenshot 2021-01-29 182742 2) Read Chapter 9.5 Screenshot 2021-01-29 182829 3) Read Chapter 10 Screenshot 2021-01-29 183100 4) Read Chapter 11 Screenshot 2021-01-29 183149

Steps: Ex. -2 https://mangadex.org/title/31792/mieruko-chan 1) Read Chapter 14 Screenshot 2021-01-29 183705 2) Read Chapter 14.2 Screenshot 2021-01-29 183836 3) Read Chapter 14.5 Screenshot 2021-01-29 183908 4) Read Chapter 15 Screenshot 2021-01-29 183940

Glagan commented 3 years ago

Seems like this is an issue related to Mangadex rather than SyncDex, I sent a message to find if I'm correct.

I looked at the request I send and I never manually update to chapter 10.5 (for the first example), it's only when you open a chapter and when the progress is automatically updated server side (I don't update MangaDex Progress when reading, since they do it themselves).

Glagan commented 3 years ago

This is an error in MangaDex, but I added a fix to avoid that and it should be good with the next version (0.2.8).

Zw012d commented 3 years ago

This is an error in MangaDex, but I added a fix to avoid that and it should be good with the next version (0.2.8).

Thanks it is now fixed

Seems like this is an issue related to Mangadex rather than SyncDex, I sent a message to find if I'm correct.

I see so Mangadex team also working on the fix from their end so i guess when it fixed from their end we can remove the temp fix from Syncdex.

Jerrk commented 3 years ago

If i import a service (specifically anilist in this case) it doesn't seem like the reading progress gets updated to match that.

is that possible to fix as well?

Glagan commented 3 years ago

@Jerrk I'm not sure to understand.

Do you want the Reading progress to be updated on Import ?
Import a Service only update your local save.

Is there an error where the MangaDex reading progress does not get updated after an Anilist Import, or does the MangaDex export do not update the MangaDex reading progress ?

Jerrk commented 3 years ago

MangaDex reading progress does not get updated after an Anilist Import

i believe is the issue.

Say i have up to chapter 60 tracked on anilist but only 30 tracked on mangadex with the reading progress. If i click "import" on the anilist service the mangadex reading progress is not updated until i actually navigate to the title page (which seems to indicate the reading progress gets pulled from the services on the page load, and not on the import).

Its possible i'm misunderstanding the import/4export process since there is both a "service import/export" and a general "import/export" for MMD, SD, and MD.

So what i specifically want is that service importing should update the mangadex reading progress if possible

Glagan commented 3 years ago

It's not a bug.
Service Import only import the list on a service to your local save and doesn't update another external service, MangaDex included.
I can't add a MangaDex sync after any Import since it's not the expected behavior, and not everybody want to sync MangaDex after an Import.

You can manually click the MangaDex export button if you want to update the Reading Progress after an Anilist Import.

Jerrk commented 3 years ago

okay gotcha so doing a service import adds the tracking information from that service to your local save - got it. service export takes all of your local save tracking information and sends it to that specific service if there are matching IDs. Since MD is not a service you are unable to export your local save tracking information to its reading progress.

Exporting your local save to MD does not update the reading progress which is what my current issue is.

so the import from a service to my local save works as it should. When i then try to export my local save to MD, MD's reading progress does not update with the tracking information of the local save

So the mangadex export button does not work for updating the MD reading progress from the local save

been a couple of weeks so i actually forgot what my actual issue was for a bit and i might've given you the wrong idea😂

so what i actaully meant was the latter part of your question

does the MangaDex export do not update the MangaDex reading progress

so the solution of

You can manually click the MangaDex export button if you want to update the Reading Progress after an Anilist Import

is what does not work 🙂

Glagan commented 3 years ago

I was actually not checking for the progress when filtering the Titles before exporting !
This will be fixed in the next version (0.2.14).

Jerrk commented 3 years ago

it somewhat works now but there seems to be an error/getting stuck with certain titles.

image

image

https://mangadex.org/title/455/my-lovely-ghost-kana

If i remove this title and run the export it will get stuck on another (H) manga/manhwa. Some titles in the "plan to read" list also get stuck. (there is another issue i found here where if mangaupdates status is set to complete, if you remove it in your local save it does not update the status on mangaupdates. if the status is set to reading however - removing from local save does remove from mangaupdates. seems to be an issue where if something is set to completed on mangaupdates you need to change the staatus first to be able to remove it)

Glagan commented 3 years ago

Seems like I missed something in the MangaDex API documentation, some titles (all "H" titles) were missing in the returned list endpoints, I added them.
I also missed a check if the title wasn't already in your MangaDex list, it should be fine now.

It's another probably unrelated issue for MangaUpdates but I'll look at it.

Glagan commented 3 years ago

The MangaUpdates error will be fixed in version 0.2.15.

Open another issue if you have another bug not related to the MangaDex progress.