search

GlareDB / glaredb

GlareDB: An analytics DBMS for distributed data
https://glaredb.com
GNU Affero General Public License v3.0
674 stars 39 forks source link

test(integration): `cloud_upload` #2675

Open greyscaled opened 8 months ago

greyscaled commented 8 months ago

As a follow-up to #2670:

we could probably write tests for this using mino or the mock gcs fixture

Originally posted by @tychoish in https://github.com/GlareDB/glaredb/issues/2670#issuecomment-1956605809

greyscaled commented 8 months ago

I think mock gcs fixture would be best - but this code relies on a cloud instance. Do we have prior art for running such tests without reaching out to a test instance of glaredb cloud?

Intuitively, I'd think we can start a glaredb connected to the gcs fixture and then use a client to connect to it via pg or rpc.

If such a test or pieces of it exist, I'd be very thankful to be pointed to the code(s).

tychoish commented 8 months ago

I think it doesn't require cloud, as much as a glaredb invocation that has credentials for the service account that can access the buckets where native storage is, and one user, but I might be missing something

greyscaled commented 8 months ago

Yes I didn't mean to imply cloud is absolutely required the confusing phrase cloud instance arises from the name of the function on session vars.

Oops.

But ya I would think we need to run the binary with the right things configured and I'm unsure if we have any existing tests doing that so it may end up being a novel setup.

Will have bandwidth to look into this more in the coming sprints