search

GlareDB / glaredb

GlareDB: An analytics DBMS for distributed data
https://glaredb.com
GNU Affero General Public License v3.0
550 stars 36 forks source link

feat: Support cloud uploads for Excel/BSON #2851

Closed vrongmeal closed 1 month ago

vrongmeal commented 1 month ago

Fixes #2829

vrongmeal commented 1 month ago

@greyscaled I am not sure how to test this. I tried testing on local, it threw an error. Need some workarounds to test it myself. Can you test this easily? If not, I can make some changes in code to test this by myself.

greyscaled commented 1 month ago

@greyscaled I am not sure how to test this. I tried testing on local, it threw an error. Need some workarounds to test it myself. Can you test this easily? If not, I can make some changes in code to test this by myself.

The simple answer is no (https://github.com/GlareDB/glaredb/issues/2675).

What I did originally and what we can do for you in this branch is deploy this branch to QA. I'll message you more details on Slack.

vrongmeal commented 1 month ago

@greyscaled I was able to test this on local. Things seem to be working fine.

tychoish commented 1 month ago

was just thinking that cloud_upload resolves a full path and then use the object store table function picker.

vrongmeal commented 1 month ago

was just thinking that cloud_upload resolves a full path and then use the object store table function picker.

Yeah, I was thinking the same thing. The issue is how those functions resolve object store. It's completely different. We'll eventually end up with this. The duplication exists because of our structures.

vrongmeal commented 1 month ago

@tychoish is this good to merge?