search

GlareDB / glaredb

GlareDB: An analytics DBMS for distributed data
https://glaredb.com
GNU Affero General Public License v3.0
535 stars 35 forks source link

refactor: use "arc<mutex<session>>" in repl #2932

Closed universalmind303 closed 3 weeks ago

universalmind303 commented 3 weeks ago

very small PR to use Arc<Mutex<>> in the repl for TrackedSession. Just some prereq work for adding tab completions.

tychoish commented 3 weeks ago

Not sure I understand why this is needed, but not otherwise objectionable.,

universalmind303 commented 3 weeks ago

Not sure I understand why this is needed, but not otherwise objectionable.

The completer needs a session to execute the queries for tables/schemas/etc. We can hold off on merging this until I have a bit of the other work done as well. This is mostly my attempt to keep the PR's smaller and more manageable for reviewing.

tychoish commented 3 weeks ago

The completer needs a session to execute the queries for tables/schemas/etc. We can hold off on merging this until I have a bit of the other work done as well. This is mostly my attempt to keep the PR's smaller and more manageable for reviewing.

Definitely appreciate it. Maybe let's let it sit and build a stack on top of it.