search

Glasgow-ICG / optical-gating-alignment

Open-source algorithms for adaptive prospective optical gating in cardiac fluorescence microscopy.
GNU General Public License v3.0
0 stars 0 forks source link

py_sad_correlation #10

Open ChasNelson1990 opened 4 years ago

ChasNelson1990 commented 4 years ago

Technically, this is a different project that hasn't been made open yet... but j_py_sad_correlation.sad_grid can't handle uint16 image sequences.

ChasNelson1990 commented 4 years ago

Also, it can't handle being passed a list.

ChasNelson1990 commented 4 years ago

@jmtayloruk this is very much your area of expertise, I don't see why this can't be done? I believe it could be as simple as changing lines 235/6 in the cpp to include both uint8 and uint16?

jmtayloruk commented 4 years ago

Agree that it should not be hard to support uint16. It will require a slight rejig of the code as there are rather more instances than just those two lines, but this is what C++ templates are for.

A list would be a bit more of a faff and would probably require a completely separate code branch. Is this something you particularly need, or are you easily able to adapt your calling code to work with a 3D array?

ChasNelson1990 commented 4 years ago

I think we can ignore the list - I think there should be enough catches for that now.