search

GlasgowEmbedded / glasgow

Scots Army Knife for electronics
BSD Zero Clause License
1.93k stars 189 forks source link

applet.control.servo: modify to use port groups #634

Closed isabelburgos closed 4 months ago

isabelburgos commented 4 months ago

Part of #599.
This one seems straightforward. I tested that it builds for revC3 with no errors, with and without a --pin-out argument.

whitequark commented 4 months ago

This PR breaks tests (you need to remove the first get_port_group); actually the error message we show for this is terrible and we should do a better one.

Once you do that, please squash the commits (you can use the "fixup" rebase command to discard their useless messages) and we're good to go!

whitequark commented 4 months ago

Your commit message actually ended up having some unrelated junk in it. Although not a huge issue in this case, we try to keep the git history readable and free of autogenerated noise that can end up in it if you use e.g. GitHub's web interface. Could you remove it please?

whitequark commented 4 months ago

Thanks for all the updates!