applet.memory.onfi: add an option to toggle internal pull-up for R/B#

GlasgowEmbedded / glasgow

Scots Army Knife for electronics

BSD Zero Clause License

1.93k stars 189 forks source link

applet.memory.onfi: add an option to toggle internal pull-up for R/B# #698

Closed haroldm closed 2 months ago

haroldm commented 2 months ago

Instead of using an external pull-up on R/B# (for instance as shown in this blog post), it is more convenient to use an internal one.

This PR adds an option to do that and doesn't change default behaviour.

whitequark commented 2 months ago

The applet predates revC, and so it was built without controllable pull-ups. Please make it non-optional; on revA/B, there will be a message instructing to add an external pull-up. There isn't really a reason to have it optional.

haroldm commented 2 months ago

It should be good now, thanks.

haroldm commented 2 months ago

Forgot to change the commit message, sorry.

whitequark commented 2 months ago

Unfortunately you did that after I added it to the queue, so the change didn't go in.