GlassBricks / StagedBlueprintPlanning

The ultimate Factorio mod for advanced blueprint planning.
GNU Lesser General Public License v3.0
10 stars 2 forks source link

Upgraded entities leave behind undeletable entity preview #45

Closed SophieFitz closed 5 months ago

SophieFitz commented 5 months ago

If in one stage you upgrade any entity to a higher tier and then subsequently need to remove said entity completely (i.e. from the first stage it appears in), right-click only removes the non-upgraded version of the entity. It leaves behind a preview that appears in all stages. Force deleting doesn't work and outputs an error to the factorio-current.log file.

Undeletable underground belts Underground belt (before right-click removal)

GlassBricks commented 5 months ago

This is probably due to a bad mod interaction. Could you specify what entities (from what mods) you were working with, so I can investigate deeper? A save file may also be useful.

SophieFitz commented 5 months ago

Just tested with no mods except for yours, same issue. Tried putting an underground belt pair down, upgraded in a later stage (to fast undergrounds) then attempted deleting from first stage. Leaves behind same weird entity preview (with the white highlight surrounding it). Same error in log file.

GlassBricks commented 5 months ago

The white underground is intentional and can be (should be) removable with the cleanup tool or force delete. The error is a bug though; looking into it.

SophieFitz commented 5 months ago

No worries, thanks for looking into it! Tried the cleanup tool just now and it gives the same error :( After using the cleanup tool though, the Stage Info panel is gone when I select the belt, but the belt is still there! So it does something, just not the whole thing I guess haha

Is the white highlight the easiest way to deal with deleting entities that span multiple stages like this? As in, deleting from base stage, it still appearing in future stages so then cleanup tool to get rid of the rest? Not entirely sure what you mean by intentional

GlassBricks commented 5 months ago

It's there so that using "undo" still works (preserves the upgrade info); see "settings remnant" in the mod description for more info.

I've had many debates as to if this "feature" is worth it; I think I'll make it user-configurable if they appear or not in the near future.

SophieFitz commented 5 months ago

Got you. Didn't realise it was a feature, kind of assumed it wasn't as I couldn't delete the remnant once it was there (it appearing in all future stages is confusing too). Yeah configurable option might be best. It's a neat idea but it wasn't intuitive for me to grasp haha. Maybe a different icon in the corner to easily denote the remnant's purpose? Like the undo arrow icon? Not sure if that would be more intuitive or not, but might be clearer than the white highlight?

Okay, so the force delete tool actually does what I want it to do. And pressing undo preserves the upgrade status through stages! So shall use that from now on.

GlassBricks commented 5 months ago

Anyways, the underground deletion bug should be fixed in v0.30.5. You should be able to force delete/use cleanup tool on them now.

As a tip, if needed you can click "Rebuild all stages" to resolve inconsistencies (like undeletable previews).