search

GlassBricks / typed-factorio

Complete and featureful Typescript defintions for the Factorio modding API
MIT License
33 stars 3 forks source link

LuaEntity name is "inserter" | "filter-inserter" #2

Closed aSemy closed 2 years ago

aSemy commented 2 years ago

Hey. I'm new to Typescript and Lua so I might be mistaken but I thought I'd write a quick issue just in case.

LuaEntity has a name field, but I think it should be any string, not just limited to inserter or filter-inserter.

node_modules\typed-factorio\generated\classes.d.ts line 2394

  /**
   * Name of the entity prototype. E.g. "inserter" or "filter-inserter".
   *
   * {@link https://lua-api.factorio.com/next/LuaEntity.html#LuaEntity.name View documentation}
   */
  readonly name: "inserter" | "filter-inserter"

I have typed-factorio version 0.7.3

image

GlassBricks commented 2 years ago

It's getting that (wrongly) from the description. Fixed in 0.7.4