Closed blurp1478963 closed 7 years ago
It looks like you might have a missing dependency. Would you mind trying this and let me know if it solves the problem: apm install atom-image-resize
. This is curious because I wasn't aware Atom Beautify had such a dependency.
I'm facing the same issue
I have the same issue. I tried app install atom-image-resize
and atom-image-resize is there. The error is in the image-resize package... in the file main.coffee as mentioned in the error message :
package.coffee:410 Error serializing package 'atom-image-resize' TypeError: Cannot read property 'serialize' of undefined
at Object.serialize (/Users/gregori/.atom/packages/atom-image-resize/lib/main.coffee:38:41)
at Package.module.exports.Package.serialize (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package.js:668:97)
at PackageManager.module.exports.PackageManager.serializePackage (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package-manager.js:617:63)
at PackageManager.module.exports.PackageManager.serialize (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/package-manager.js:610:14)
at AtomEnvironment.module.exports.AtomEnvironment.serialize (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/atom-environment.js:849:38)
at /Applications/Atom Beta.app/Contents/Resources/app.asar/src/atom-environment.js:1054:27
at AtomEnvironment.module.exports.AtomEnvironment.saveState (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/atom-environment.js:1050:14)
at /Applications/Atom Beta.app/Contents/Resources/app.asar/src/atom-environment.js:353:28
It works on Typescript file, but fails on this HTML one for example: https://raw.githubusercontent.com/gregorifaroux/digiangular2/master/src/app/reddit-simple/reddit-simple.component.html
<div class="ui masthead vertical segment">
<div class="ui container">
<h1>Add a link</h1>
<div class="ui divider"></div>
</div>
<div class="main ui container">
<form class="ui form">
<div class="field">
<label for="title">Title</label>
<input label="Title" placeholder="Title..." name="title" #newtitle/>
</div>
<div class="field">
<label for="link">Link</label>
<input label="Link" placeholder="Link..." name="link" #newlink/>
</div>
<sm-button class="primary" (click)="addArticle(newtitle, newlink)">Submit</sm-button>
</form>
<div class="ui divider"></div>
<div class="ui cards">
<app-reddit-article *ngFor = "let article of articles"
[article] = "article">
</app-reddit-article>
</div>
</div>
</div>
MacOS Sierra 10.12 + Atom 1.12.9 + Atom-Beautify 0.29.16, facing the same issue~~
Same exact issue. OSX El Capitan 10.11.6, Atom 1.13.0, Atom-Beautify 0.29.16
Issue on macOS Sierra 10.12.2 and I tried both the latest Atom and Atom Beta 1.13.0-beta10. atom-beautify 0.29.16, image-resize installed in .atom/packages.
It works on Atom 1.12.7, beautify 0.29.13, no image-resize installed in .atom/packages
It seems that beautify used to work without image-resize. Any idea why there is a new dependency?
I confirmed that reversing to 0.29.13 remove the error.
Steps:
apm-beta install atom-beautify@0.29.13 or apm install atom-beautify@0.29.13
It stopped working at the version 0.29.15
It works at the version 0.29.14.
As a temporary workaround I recommend 0.29.14.
@greenkeeperio-bot Thx! , it's looks like working fine at 0.29.14~
This looks to be an atom-image-resize
bug at:
https://github.com/geekduck/atom-image-resize/blob/master/lib/main.coffee#L38
I recommend someone submit a Pull Request to https://github.com/geekduck/atom-image-resize which resolves the problem on their end.
Issue on macOS Sierra 10.12.2 and I tried both the latest Atom and Atom Beta 1.13.0-beta10. atom-beautify 0.29.16, image-resize installed in .atom/packages.
It works on Atom 1.12.7, beautify 0.29.13, no image-resize installed in .atom/packages
If you disable atom-image-resize
, reload Atom, and try Atom-Beautify again with v0.29.15 does this atom-image-resize
error still appear and consequently break Atom-Beautify?
It seems that beautify used to work without image-resize. Any idea why there is a new dependency?
atom-image-resize
is not a dependency of Atom-Beautify: https://github.com/Glavin001/atom-beautify/search?q=image+resize&type=Code&utf8=%E2%9C%93
I tried both the latest Atom and Atom Beta 1.13.0-beta10. atom-beautify 0.29.16, image-resize installed in .atom/packages.
Please disable atom-image-resize
and then retry with the latest Atom-Beautify to confirm if this is truly an Atom-Beautify issue. Thanks! 😄
@Glavin001, I don't have atom-image-resize installed. It is only HTML as I can see
I've found that another workaround is to run Atom (or Atom Beta) in dev mode:
atom -d
atom-beta -d
I've tried to disable atom-image-resize but no changes (even that the atom-image-resize js error disappear!)... The panel stay in "Beautification in progress". The issue appears only for html files. I didn't mention it before.
What kind of debug info can I give to help debugging? I'm not an expert of atom background processes and debug...!
PS:
I don't have atom-image-resize installed.
and
I've tried to disable atom-image-resize but no changes (even that the atom-image-resize js error disappear!)...
So at least we know now the issue is not related to atom-image-resize
whatsoever.
The issue appears only for html files.
HTML files are supported by both JS Beautify
and Pretty Diff
. We need more information. Everyone please attempt to create a debug.md
Gist by following the step 1 instructions found at https://github.com/Glavin001/atom-beautify/blob/master/CONTRIBUTING.md#new-issues-bugs-questions-etc
I try to follow instructions to make a debug.md but... same issue! the new debug tab doesn't appear and the panel 'Atom Beautify' (Beautification in progress) is blocked...
You could try configuring Atom-Beautify to show more logging info with Logger Level
set to verbose
: https://github.com/Glavin001/atom-beautify/blob/master/docs/options.md#logger-level
Then open the JavaScript Developer console in Atom before running beautification and see if you find anything interesting to share.
On a simple HTML page:
<h1>Hello</h1>
I get the following verbose log; there are some null and undefined, but so far I cant see anything obvious:
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: /Users/gfaroux null /Users/gfaroux/.jsbeautifyrc Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: configPath null /Users/gfaroux/FAKEFILENAME false
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: /Users/gfaroux/Documents/Atom/digiangular2/src null /Users/gfaroux/.jsbeautifyrc Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: configPath null /Users/gfaroux/Documents/Atom/digiangular2/src/FAKEFILENAME false
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: /Users/gfaroux/Documents/Atom/digiangular2 null /Users/gfaroux/.jsbeautifyrc Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: configPath null /Users/gfaroux/Documents/Atom/digiangular2/FAKEFILENAME false
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: /Users/gfaroux/Documents/Atom null /Users/gfaroux/.jsbeautifyrc Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: configPath null /Users/gfaroux/Documents/Atom/FAKEFILENAME false
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: /Users/gfaroux/Documents null /Users/gfaroux/.jsbeautifyrc Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: configPath null /Users/gfaroux/Documents/FAKEFILENAME false
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: /Users/gfaroux null /Users/gfaroux/.jsbeautifyrc Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: configPath null /Users/gfaroux/FAKEFILENAME false
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: /Users null /Users/gfaroux/.jsbeautifyrc Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: configPath null /Users/FAKEFILENAME false
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: editorConfigOptions Object {charset: "utf-8", indent_style: "space", indent_size: 2, insert_final_newline: true, trim_trailing_whitespace: true…}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [info]: beautify <h1>Hello</h1> [ { _default: { indent_size: 2, indent_char: ' ', indent_with_tabs: false } },
{ apex:
{ configPath: '',
disabled: false,
default_beautifier: 'Uncrustify',
beautify_on_save: false },
arduino:
{ configPath: '',
disabled: false,
default_beautifier: 'Uncrustify',
beautify_on_save: false },
bash:
{ indent_size: 2,
disabled: false,
default_beautifier: 'beautysh',
beautify_on_save: false },
cs:
{ configPath: '',
disabled: false,
default_beautifier: 'Uncrustify',
beautify_on_save: false },
c:
{ configPath: '',
disabled: false,
default_beautifier: 'Uncrustify',
beautify_on_save: false },
clj:
{ disabled: false,
default_beautifier: 'cljfmt',
beautify_on_save: false },
coffeescript:
{ indent_size: 4,
indent_char: ' ',
indent_level: 0,
indent_with_tabs: false,
preserve_newlines: true,
max_preserve_newlines: 10,
space_in_paren: false,
jslint_happy: false,
space_after_anon_function: false,
brace_style: 'collapse',
break_chained_methods: false,
keep_array_indentation: false,
keep_function_indentation: false,
space_before_conditional: true,
eval_code: false,
unescape_strings: false,
wrap_line_length: 0,
end_with_newline: false,
end_with_comma: false,
disabled: false,
default_beautifier: 'coffee-fmt',
beautify_on_save: false },
cfml:
{ indent_size: 4,
indent_char: ' ',
wrap_line_length: 250,
preserve_newlines: true,
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
cpp:
{ configPath: '',
disabled: false,
default_beautifier: 'Uncrustify',
beautify_on_save: false },
crystal:
{ disabled: false,
default_beautifier: 'Crystal',
beautify_on_save: false },
css:
{ indent_size: 4,
indent_char: ' ',
selector_separator_newline: false,
newline_between_rules: true,
preserve_newlines: false,
wrap_line_length: 0,
end_with_newline: false,
indent_comments: true,
force_indentation: false,
convert_quotes: 'none',
align_assignments: false,
no_lead_zero: false,
configPath: '',
predefinedConfig: 'csscomb',
disabled: false,
default_beautifier: 'JS Beautify',
beautify_on_save: false },
csv:
{ disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
d:
{ configPath: '',
disabled: false,
default_beautifier: 'Uncrustify',
beautify_on_save: false },
ejs:
{ indent_size: 4,
indent_char: ' ',
indent_level: 0,
indent_with_tabs: false,
preserve_newlines: true,
max_preserve_newlines: 10,
space_in_paren: false,
jslint_happy: false,
space_after_anon_function: false,
brace_style: 'collapse',
break_chained_methods: false,
keep_array_indentation: false,
keep_function_indentation: false,
space_before_conditional: true,
eval_code: false,
unescape_strings: false,
wrap_line_length: 250,
end_with_newline: false,
end_with_comma: false,
indent_inner_html: false,
indent_scripts: 'normal',
wrap_attributes: 'auto',
wrap_attributes_indent_size: 4,
unformatted: [Object],
extra_liners: [Object],
disabled: false,
default_beautifier: 'JS Beautify',
beautify_on_save: false },
elm:
{ disabled: false,
default_beautifier: 'elm-format',
beautify_on_save: false },
erb:
{ indent_size: 4,
indent_char: ' ',
wrap_line_length: 250,
preserve_newlines: true,
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
erlang:
{ disabled: false,
default_beautifier: 'erl_tidy',
beautify_on_save: false },
gherkin:
{ indent_size: 4,
indent_char: ' ',
disabled: false,
default_beautifier: 'Gherkin formatter',
beautify_on_save: false },
glsl:
{ configPath: '',
disabled: false,
default_beautifier: 'clang-format',
beautify_on_save: false },
go:
{ disabled: false,
default_beautifier: 'gofmt',
beautify_on_save: false },
fortran:
{ emacs_path: '',
emacs_script_path: '',
disabled: false,
default_beautifier: 'Fortran Beautifier',
beautify_on_save: false },
handlebars:
{ indent_inner_html: false,
indent_size: 4,
indent_char: ' ',
brace_style: 'collapse',
indent_scripts: 'normal',
wrap_line_length: 250,
wrap_attributes: 'auto',
wrap_attributes_indent_size: 4,
preserve_newlines: true,
max_preserve_newlines: 10,
unformatted: [Object],
end_with_newline: false,
extra_liners: [Object],
disabled: false,
default_beautifier: 'JS Beautify',
beautify_on_save: false },
haskell:
{ disabled: false,
default_beautifier: 'stylish-haskell',
beautify_on_save: false },
html:
{ indent_inner_html: false,
indent_size: 4,
indent_char: ' ',
brace_style: 'collapse',
indent_scripts: 'normal',
wrap_line_length: 250,
wrap_attributes: 'auto',
wrap_attributes_indent_size: 4,
preserve_newlines: true,
max_preserve_newlines: 10,
unformatted: [Object],
end_with_newline: false,
extra_liners: [Object],
disabled: false,
default_beautifier: 'JS Beautify',
beautify_on_save: false },
jade:
{ indent_size: 4,
indent_char: ' ',
disabled: false,
default_beautifier: 'Pug Beautify',
beautify_on_save: false },
java:
{ configPath: '',
disabled: false,
default_beautifier: 'Uncrustify',
beautify_on_save: false },
js:
{ indent_size: 2,
indent_char: ' ',
indent_level: 0,
indent_with_tabs: false,
preserve_newlines: true,
max_preserve_newlines: 10,
space_in_paren: false,
jslint_happy: false,
space_after_anon_function: false,
brace_style: 'collapse',
break_chained_methods: false,
keep_array_indentation: false,
keep_function_indentation: false,
space_before_conditional: true,
eval_code: false,
unescape_strings: false,
wrap_line_length: 0,
end_with_newline: false,
end_with_comma: false,
disabled: false,
default_beautifier: 'JS Beautify',
beautify_on_save: false },
json:
{ indent_size: 4,
indent_char: ' ',
indent_level: 0,
indent_with_tabs: false,
preserve_newlines: true,
max_preserve_newlines: 10,
space_in_paren: false,
jslint_happy: false,
space_after_anon_function: false,
brace_style: 'collapse',
break_chained_methods: false,
keep_array_indentation: false,
keep_function_indentation: false,
space_before_conditional: true,
eval_code: false,
unescape_strings: false,
wrap_line_length: 0,
end_with_newline: false,
end_with_comma: false,
disabled: false,
default_beautifier: 'JS Beautify',
beautify_on_save: false },
jsx:
{ indent_size: 4,
indent_char: ' ',
indent_level: 0,
indent_with_tabs: false,
preserve_newlines: true,
max_preserve_newlines: 10,
space_in_paren: false,
jslint_happy: false,
space_after_anon_function: false,
brace_style: 'collapse',
break_chained_methods: false,
keep_array_indentation: false,
keep_function_indentation: false,
space_before_conditional: true,
eval_code: false,
unescape_strings: false,
wrap_line_length: 0,
end_with_newline: false,
end_with_comma: false,
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
latex:
{ indent_char: ' ',
indent_with_tabs: true,
indent_preamble: false,
always_look_for_split_braces: true,
always_look_for_split_brackets: false,
remove_trailing_whitespace: false,
align_columns_in_environments: [Object],
disabled: false,
default_beautifier: 'Latex Beautify',
beautify_on_save: false },
less:
{ indent_size: 4,
indent_char: ' ',
newline_between_rules: true,
preserve_newlines: false,
wrap_line_length: 0,
indent_comments: true,
force_indentation: false,
convert_quotes: 'none',
align_assignments: false,
no_lead_zero: false,
configPath: '',
predefinedConfig: 'csscomb',
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
lua:
{ disabled: false,
default_beautifier: 'Lua beautifier',
beautify_on_save: false },
markdown:
{ gfm: true,
yaml: true,
commonmark: false,
disabled: false,
default_beautifier: 'Tidy Markdown',
beautify_on_save: false },
marko:
{ indent_size: 4,
indent_char: ' ',
syntax: 'html',
indent_inner_html: false,
brace_style: 'collapse',
indent_scripts: 'normal',
wrap_line_length: 250,
wrap_attributes: 'auto',
wrap_attributes_indent_size: 4,
preserve_newlines: true,
max_preserve_newlines: 10,
unformatted: [Object],
end_with_newline: false,
extra_liners: [Object],
disabled: false,
default_beautifier: 'Marko Beautifier',
beautify_on_save: false },
mustache:
{ indent_inner_html: false,
indent_size: 4,
indent_char: ' ',
brace_style: 'collapse',
indent_scripts: 'normal',
wrap_line_length: 250,
wrap_attributes: 'auto',
wrap_attributes_indent_size: 4,
preserve_newlines: true,
max_preserve_newlines: 10,
unformatted: [Object],
end_with_newline: false,
extra_liners: [Object],
disabled: false,
default_beautifier: 'JS Beautify',
beautify_on_save: false },
nunjucks:
{ indent_size: 4,
indent_char: ' ',
wrap_line_length: 250,
preserve_newlines: true,
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
objectivec:
{ configPath: '',
disabled: false,
default_beautifier: 'Uncrustify',
beautify_on_save: false },
ocaml:
{ disabled: false,
default_beautifier: 'ocp-indent',
beautify_on_save: false },
pawn:
{ configPath: '',
disabled: false,
default_beautifier: 'Uncrustify',
beautify_on_save: false },
perl:
{ perltidy_profile: '',
disabled: false,
default_beautifier: 'Perltidy',
beautify_on_save: false },
php:
{ cs_fixer_path: '',
fixers: '',
level: '',
phpcbf_path: '',
standard: '',
disabled: false,
default_beautifier: 'PHP-CS-Fixer',
beautify_on_save: false },
puppet:
{ disabled: false,
default_beautifier: 'puppet-lint',
beautify_on_save: false },
python:
{ max_line_length: 79,
indent_size: 4,
ignore: [Object],
sort_imports: false,
disabled: false,
default_beautifier: 'autopep8',
beautify_on_save: false },
r:
{ indent_size: 4,
disabled: false,
default_beautifier: 'formatR',
beautify_on_save: false },
riot:
{ indent_size: 4,
indent_char: ' ',
wrap_line_length: 250,
preserve_newlines: true,
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
ruby:
{ indent_size: 4,
rubocop_path: '',
indent_char: ' ',
disabled: false,
default_beautifier: 'Rubocop',
beautify_on_save: false },
rust:
{ rustfmt_path: '',
disabled: false,
default_beautifier: 'rustfmt',
beautify_on_save: false },
sass:
{ disabled: false,
default_beautifier: 'SassConvert',
beautify_on_save: false },
scss:
{ indent_size: 4,
indent_char: ' ',
newline_between_rules: true,
preserve_newlines: false,
wrap_line_length: 0,
indent_comments: true,
force_indentation: false,
convert_quotes: 'none',
align_assignments: false,
no_lead_zero: false,
configPath: '',
predefinedConfig: 'csscomb',
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
spacebars:
{ indent_size: 4,
indent_char: ' ',
wrap_line_length: 250,
preserve_newlines: true,
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
sql:
{ indent_size: 4,
keywords: 'upper',
identifiers: 'unchanged',
disabled: false,
default_beautifier: 'sqlformat',
beautify_on_save: false },
svg:
{ indent_size: 4,
indent_char: ' ',
wrap_line_length: 250,
preserve_newlines: true,
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
swig:
{ indent_size: 4,
indent_char: ' ',
wrap_line_length: 250,
preserve_newlines: true,
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
tss:
{ indent_size: 4,
indent_char: ' ',
newline_between_rules: true,
preserve_newlines: false,
wrap_line_length: 0,
indent_comments: true,
force_indentation: false,
convert_quotes: 'none',
align_assignments: false,
no_lead_zero: false,
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
twig:
{ indent_size: 4,
indent_char: ' ',
indent_with_tabs: false,
preserve_newlines: true,
space_in_paren: false,
space_after_anon_function: false,
break_chained_methods: false,
wrap_line_length: 250,
end_with_comma: false,
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
typescript:
{ indent_size: 2,
indent_char: ' ',
indent_level: 0,
indent_with_tabs: false,
preserve_newlines: true,
max_preserve_newlines: 10,
space_in_paren: false,
jslint_happy: false,
space_after_anon_function: false,
brace_style: 'collapse',
break_chained_methods: false,
keep_array_indentation: false,
keep_function_indentation: false,
space_before_conditional: true,
eval_code: false,
unescape_strings: false,
wrap_line_length: 0,
end_with_newline: false,
end_with_comma: false,
disabled: false,
default_beautifier: 'TypeScript Formatter',
beautify_on_save: false },
ux:
{ indent_size: 4,
indent_char: ' ',
wrap_line_length: 250,
preserve_newlines: true,
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
vala:
{ configPath: '',
disabled: false,
default_beautifier: 'Uncrustify',
beautify_on_save: false },
vue:
{ indent_inner_html: false,
indent_size: 4,
indent_char: ' ',
brace_style: 'collapse',
indent_scripts: 'normal',
wrap_line_length: 250,
wrap_attributes: 'auto',
wrap_attributes_indent_size: 4,
preserve_newlines: true,
max_preserve_newlines: 10,
unformatted: [Object],
end_with_newline: false,
extra_liners: [Object],
disabled: false,
default_beautifier: 'Vue Beautifier',
beautify_on_save: false },
visualforce:
{ indent_size: 4,
indent_char: ' ',
wrap_line_length: 250,
preserve_newlines: true,
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
xml:
{ indent_inner_html: false,
indent_size: 4,
indent_char: ' ',
brace_style: 'collapse',
indent_scripts: 'normal',
wrap_line_length: 250,
wrap_attributes: 'auto',
wrap_attributes_indent_size: 4,
preserve_newlines: true,
max_preserve_newlines: 10,
unformatted: [Object],
end_with_newline: false,
extra_liners: [Object],
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false },
xtemplate:
{ indent_size: 4,
indent_char: ' ',
wrap_line_length: 250,
preserve_newlines: true,
disabled: false,
default_beautifier: 'Pretty Diff',
beautify_on_save: false } },
{ _default: {} },
{ _default:
{ charset: 'utf-8',
indent_style: 'space',
indent_size: 2,
insert_final_newline: true,
trim_trailing_whitespace: true,
tab_width: 2,
indent_char: ' ' } },
{ _default: {} },
{ _default: {} },
{ _default: {} },
{ _default: {} },
{ _default: {} },
{ _default: {} } ] HTML (Angular) /Users/gfaroux/Documents/Atom/digiangular2/src/index.html undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: [Object, Object, Object, Object, Object, Object, Object, Object, Object, Object]
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: [ { name: 'EJS',
description: 'Embedded JavaScript',
namespace: 'ejs',
fallback: [ 'html', 'js' ],
grammars: [ 'EJS', 'JavaScript Template', 'HTML (Angular)' ],
extensions: [ 'ejs' ],
options: [] },
{ name: 'HTML',
namespace: 'html',
grammars: [ 'HTML' ],
extensions: [ 'html' ],
options:
{ indent_inner_html: [Object],
indent_size: [Object],
indent_char: [Object],
brace_style: [Object],
indent_scripts: [Object],
wrap_line_length: [Object],
wrap_attributes: [Object],
wrap_attributes_indent_size: [Object],
preserve_newlines: [Object],
max_preserve_newlines: [Object],
unformatted: [Object],
end_with_newline: [Object],
extra_liners: [Object] } } ] 'HTML (Angular)' 'html' Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: Language EJS supported Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: getOptions selections [ 'html', 'js', 'ejs' ] [Object, Object, Object, Object, Object, Object, Object, Object, Object, Object]
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: true Object {_default: Object}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html Object {indent_size: 2, indent_char: " ", indent_with_tabs: false}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js Object {indent_size: 2, indent_char: " ", indent_with_tabs: false}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs Object {indent_size: 2, indent_char: " ", indent_with_tabs: false}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: true Object {apex: Object, arduino: Object, bash: Object, cs: Object, c: Object…}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html Object {indent_inner_html: false, indent_size: 4, indent_char: " ", brace_style: "collapse", indent_scripts: "normal"…}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html Object {indent_inner_html: false, indent_size: 4, indent_char: " ", brace_style: "collapse", indent_scripts: "normal"…}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js Object {indent_size: 2, indent_char: " ", indent_level: 0, indent_with_tabs: false, preserve_newlines: true…}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js Object {indent_inner_html: false, indent_size: 4, indent_char: " ", brace_style: "collapse", indent_scripts: "normal"…}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs Object {indent_size: 4, indent_char: " ", indent_level: 0, indent_with_tabs: false, preserve_newlines: true…}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs Object {indent_inner_html: false, indent_size: 4, indent_char: " ", brace_style: "collapse", indent_scripts: "normal"…}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: true Object {_default: Object}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: true Object {_default: Object}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html Object {charset: "utf-8", indent_style: "space", indent_size: 2, insert_final_newline: true, trim_trailing_whitespace: true…}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js Object {charset: "utf-8", indent_style: "space", indent_size: 2, insert_final_newline: true, trim_trailing_whitespace: true…}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs Object {charset: "utf-8", indent_style: "space", indent_size: 2, insert_final_newline: true, trim_trailing_whitespace: true…}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: true Object {_default: Object}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: true Object {_default: Object}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: true Object {_default: Object}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: true Object {_default: Object}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: true Object {_default: Object}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: true Object {_default: Object}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options html Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options js Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs undefined
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: options ejs Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: HTML (Angular) Object {name: "EJS", description: "Embedded JavaScript", namespace: "ejs", fallback: Array[2], grammars: Array[3]…}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: language options: {
"indent_size": 2,
"indent_char": " ",
"indent_with_tabs": false,
"indent_inner_html": false,
"brace_style": "collapse",
"indent_scripts": "normal",
"wrap_line_length": 250,
"wrap_attributes": "auto",
"wrap_attributes_indent_size": 4,
"preserve_newlines": true,
"max_preserve_newlines": 10,
"unformatted": [
"a",
"abbr",
"area",
"audio",
"b",
"bdi",
"bdo",
"br",
"button",
"canvas",
"cite",
"code",
"data",
"datalist",
"del",
"dfn",
"em",
"embed",
"i",
"iframe",
"img",
"input",
"ins",
"kbd",
"keygen",
"label",
"map",
"mark",
"math",
"meter",
"noscript",
"object",
"output",
"progress",
"q",
"ruby",
"s",
"samp",
"select",
"small",
"span",
"strong",
"sub",
"sup",
"svg",
"template",
"textarea",
"time",
"u",
"var",
"video",
"wbr",
"text",
"acronym",
"address",
"big",
"dt",
"ins",
"small",
"strike",
"tt",
"pre",
"h1",
"h2",
"h3",
"h4",
"h5",
"h6"
],
"end_with_newline": false,
"extra_liners": [
"head",
"body",
"/html"
],
"disabled": false,
"default_beautifier": "JS Beautify",
"beautify_on_save": false,
"indent_level": 0,
"space_in_paren": false,
"jslint_happy": false,
"space_after_anon_function": false,
"break_chained_methods": false,
"keep_array_indentation": false,
"keep_function_indentation": false,
"space_before_conditional": true,
"eval_code": false,
"unescape_strings": false,
"end_with_comma": false,
"charset": "utf-8",
"indent_style": "space",
"insert_final_newline": true,
"trim_trailing_whitespace": true,
"tab_width": 2
} Object {}
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: EJS /Users/gfaroux/Documents/Atom/digiangular2/src/index.html { indent_size: 2,
indent_char: ' ',
indent_with_tabs: false,
indent_inner_html: false,
brace_style: 'collapse',
indent_scripts: 'normal',
wrap_line_length: 250,
wrap_attributes: 'auto',
wrap_attributes_indent_size: 4,
preserve_newlines: true,
max_preserve_newlines: 10,
unformatted:
[ 'a',
'abbr',
'area',
'audio',
'b',
'bdi',
'bdo',
'br',
'button',
'canvas',
'cite',
'code',
'data',
'datalist',
'del',
'dfn',
'em',
'embed',
'i',
'iframe',
'img',
'input',
'ins',
'kbd',
'keygen',
'label',
'map',
'mark',
'math',
'meter',
'noscript',
'object',
'output',
'progress',
'q',
'ruby',
's',
'samp',
'select',
'small',
'span',
'strong',
'sub',
'sup',
'svg',
'template',
'textarea',
'time',
'u',
'var',
'video',
'wbr',
'text',
'acronym',
'address',
'big',
'dt',
'ins',
'small',
'strike',
'tt',
'pre',
'h1',
'h2',
'h3',
'h4',
'h5',
'h6' ],
end_with_newline: false,
extra_liners: [ 'head', 'body', '/html' ],
disabled: false,
default_beautifier: 'JS Beautify',
beautify_on_save: false,
indent_level: 0,
space_in_paren: false,
jslint_happy: false,
space_after_anon_function: false,
break_chained_methods: false,
keep_array_indentation: false,
keep_function_indentation: false,
space_before_conditional: true,
eval_code: false,
unescape_strings: false,
end_with_comma: false,
charset: 'utf-8',
indent_style: 'space',
insert_final_newline: true,
trim_trailing_whitespace: true,
tab_width: 2 } [Object, Object, Object, Object, Object, Object, Object, Object, Object, Object]
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: beautifiers ["JS Beautify", "Pretty Diff"]
1/11/2017 10:59:03 AM - beautifiers/index.coffee [verbose]: beautifier JS Beautify Object {}
1/11/2017 10:59:03 AM - beautifiers/beautifier.coffee [verbose]: JS Beautify language EJS Object {}
1/11/2017 10:59:03 AM - beautifiers/beautifier.coffee [info]: JS Beautify Options: {
"indent_size": 2,
"indent_char": " ",
"indent_with_tabs": false,
"indent_inner_html": false,
"brace_style": "collapse",
"indent_scripts": "normal",
"wrap_line_length": 250,
"wrap_attributes": "auto",
"wrap_attributes_indent_size": 4,
"preserve_newlines": true,
"max_preserve_newlines": 10,
"unformatted": [
"a",
"abbr",
"area",
"audio",
"b",
"bdi",
"bdo",
"br",
"button",
"canvas",
"cite",
"code",
"data",
"datalist",
"del",
"dfn",
"em",
"embed",
"i",
"iframe",
"img",
"input",
"ins",
"kbd",
"keygen",
"label",
"map",
"mark",
"math",
"meter",
"noscript",
"object",
"output",
"progress",
"q",
"ruby",
"s",
"samp",
"select",
"small",
"span",
"strong",
"sub",
"sup",
"svg",
"template",
"textarea",
"time",
"u",
"var",
"video",
"wbr",
"text",
"acronym",
"address",
"big",
"dt",
"ins",
"small",
"strike",
"tt",
"pre",
"h1",
"h2",
"h3",
"h4",
"h5",
"h6"
],
"end_with_newline": false,
"extra_liners": [
"head",
"body",
"/html"
],
"disabled": false,
"default_beautifier": "JS Beautify",
"beautify_on_save": false,
"indent_level": 0,
"space_in_paren": false,
"jslint_happy": false,
"space_after_anon_function": false,
"break_chained_methods": false,
"keep_array_indentation": false,
"keep_function_indentation": false,
"space_before_conditional": true,
"eval_code": false,
"unescape_strings": false,
"end_with_comma": false,
"charset": "utf-8",
"indent_style": "space",
"insert_final_newline": true,
"trim_trailing_whitespace": true,
"tab_width": 2
} Object {}
Looks like your file is being detected as EJS
. It is supported by both Pretty Diff
and JS Beautify
. JS Beautify
is used.
The last log lines are: https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/js-beautify.coffee#L28-L29
Afterwards I expect it to reach https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/js-beautify.coffee#L49 where it stops. This is a call to JS Beautify
directly with the following options:
{
"indent_size": 2,
"indent_char": " ",
"indent_with_tabs": false,
"indent_inner_html": false,
"brace_style": "collapse",
"indent_scripts": "normal",
"wrap_line_length": 250,
"wrap_attributes": "auto",
"wrap_attributes_indent_size": 4,
"preserve_newlines": true,
"max_preserve_newlines": 10,
"unformatted": [
"a",
"abbr",
"area",
"audio",
"b",
"bdi",
"bdo",
"br",
"button",
"canvas",
"cite",
"code",
"data",
"datalist",
"del",
"dfn",
"em",
"embed",
"i",
"iframe",
"img",
"input",
"ins",
"kbd",
"keygen",
"label",
"map",
"mark",
"math",
"meter",
"noscript",
"object",
"output",
"progress",
"q",
"ruby",
"s",
"samp",
"select",
"small",
"span",
"strong",
"sub",
"sup",
"svg",
"template",
"textarea",
"time",
"u",
"var",
"video",
"wbr",
"text",
"acronym",
"address",
"big",
"dt",
"ins",
"small",
"strike",
"tt",
"pre",
"h1",
"h2",
"h3",
"h4",
"h5",
"h6"
],
"end_with_newline": false,
"extra_liners": [
"head",
"body",
"/html"
],
"disabled": false,
"default_beautifier": "JS Beautify",
"beautify_on_save": false,
"indent_level": 0,
"space_in_paren": false,
"jslint_happy": false,
"space_after_anon_function": false,
"break_chained_methods": false,
"keep_array_indentation": false,
"keep_function_indentation": false,
"space_before_conditional": true,
"eval_code": false,
"unescape_strings": false,
"end_with_comma": false,
"charset": "utf-8",
"indent_style": "space",
"insert_final_newline": true,
"trim_trailing_whitespace": true,
"tab_width": 2
}
I do not see logs for Beautified HTML:
therefore it never reaches https://github.com/Glavin001/atom-beautify/blob/master/src/beautifiers/js-beautify.coffee#L50 indicating JS Beautify
is the likely culprit.
Could you try to reproduce using JS Beautify
directly using your configuration as found above? See https://github.com/beautify-web/js-beautify#javascript for details.
Maybe one of the options has a bug causing an infinite loop.
I tried:
$ sudo npm -g install js-beautify
$ js-beautify reddit-simple.component.html -s 4 -b collapse -S normal -p -A auto
And no issue; it produce the formatted file without any issues. I tried to match the options I use in Atom in the command line.
Is there a way to tell JS Beautify to use the Atom's config?
g
Additional information that may rule out a JS Beautify issue: In Atom, setting Default Beautifier to Pretty Diff does not make a difference; we still get the never ending 'In Progress' message.
The fix https://github.com/Glavin001/atom-beautify/pull/1432 has been merged and published.
Please update to v0.29.17! Thank you everyone for your patience!
Thank you! v0.29.17 works / corrected the issue.
Awesome! Thank you for confirming, @gregorifaroux!
Writing to this issue as It is relevant to what I am facing. I am using atom-beautify 0.32.5 , ubuntu 18.04, Atom 1.27.2. I have enabled Beautify On Save. Every time I save some changes, I am getting a large information box indicating Beautification in progress, which won't go away till I click on the hide button. Any possible way to disable this block? Help much appreciated.
EDIT:
I was able to find the fix. Thanks
Settings->General-> Uncheck Show Loading View
@tjstlekr It should disappear once beautification has completed and the file is saved.
The problem has risen again in the latest atom-beautify update I am using atom-beautify 0.33.4, Windows 10, Atom 1.49.0 Once I press CTRL + Alt + B, it shows "Beautification in Progress" and stays stuck there This issue was fixed when I downgraded to atom-beautify 0.29.17
Having the same issue here for complex Ruby erb files
Description
No Result! The little window stays in "Beautification in progress" and nothing appends
Input Before Beautification
The code is html / angular
Expected Output
Actual Output
Steps to Reproduce
Debug
Here is what appends:
Error serializing package 'atom-image-resize' TypeError: Cannot read property 'serialize' of undefined at Object.serialize (/Users/ben/.atom/packages/atom-image-resize/lib/main.coffee:38:41) at Package.module.exports.Package.serialize (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:649:97) at PackageManager.module.exports.PackageManager.serializePackage (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:617:63) at PackageManager.module.exports.PackageManager.serialize (/Applications/Atom.app/Contents/Resources/app.asar/src/package-manager.js:610:14) at AtomEnvironment.module.exports.AtomEnvironment.serialize (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:810:38) at /Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:1015:27 at AtomEnvironment.module.exports.AtomEnvironment.saveState (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:1011:14) at /Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:316:28
Checklist
I have:
debug.md
Gist to this issue