PHPCBF appears to not run from project folder

[chuhta]

Description

PHPCBF does not work with relative paths in the ruleset.xml file. It seems like from the debugging I have done that the PHPCBF process is being run from the package folder instead of from the project folder, meaning that relative paths in the ruleset break.

Input Before Beautification

This is what the ruleset looks like:

<?xml version="1.0"?>
<!DOCTYPE ruleset>
<ruleset name="Sample Standard">
    <config name="installed_paths" value="config/Standards" />

Expected Output

The code should be beautified with no errors in the console.

Actual Output

• The code is not beautified.
• The error is logged as console.log instead of console.error so it doesn't stand out.
• The relative path standards are not found.

  ./PHPCBF Executable [verbose]: spawn result, stderr PHP Fatal error:  Uncaught UnexpectedValueException: DirectoryIterator::__construct(config/Standards): failed to open dir: No such file or directory in /home/sampleUser/project/vendor/squizlabs/php_codesniffer/src/Util/Standards.php:93 
  Stack trace: #0 

Steps to Reproduce

1. Add the following settings to atom-beautify.

    executables:
      phpcbf:
        path: "/home/sampleUser/project/vendor/bin/phpcbf"
    general:
      loggerLevel: "verbose"
    php:
      default_beautifier: "PHPCBF"
      phpcbf_version: 3
      standard: "/home/sampleUser/project/config/ruleset.xml

2. Create a project with a PHPCS ruleset.
3. Add a custom sniff locally to the project. You can copy a sniff from any PHPCS library and save it to mimic this.
4. Point the ruleset to the folder containing the sniff. This should be the relative path from the project root.
5. Run command Atom Beautify: Beautify Language Php.
6. The beautify seems to have succeeded, but nothing changed.
7. Open the Developer console (Ctrl+Shift+I).
8. The error previously described prints out.

Debug

Gist: https://gist.github.com/chuhta/7e780bb9cea466be4413a51a2c0f07f3

Making the following changes to these files resolved the problem of the package not running.

src/beautifiers/phpcbf.coffee

# Lines 89-101
        phpcbf.run([
          "--no-patch" unless isVersion3
          "--standard=#{options.standard}" if options.standard
          tempFile
          ], {
+            cwd: atom.project.relativizePath(standardFile)[0],
            ignoreReturnCode: true
            onStdin: (stdin) ->
              stdin.end()
          })
          .then(=>
            @readFile(tempFile)
          )

src/beautifiers/beautifier.coffee

# Lines 152-158
      .then(([exeName, args, env, exePath]) =>
        @debug('exePath:', exePath)
        @debug('env:', env)
        @debug('PATH:', env.PATH)
        @debug('args', args)
-        args = this.relativizePaths(args)
        @debug('relativized args', args)

src/logger.coffee

No changes actually made in this file, but it appears interactions with it are not as would be expected. The error mentioned above does not appear until I turn the logging up to at least "debug", even though it is clearly an error that is blocking atom-beautifier from working.

Checklist

I have:

• [x] Tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
• [x] Reloaded (or restarted) Atom to ensure it is not a caching issue
• [x] Searched through existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues so I know this is not a duplicate issue
• [x] Filled out the Input, Expected, and Actual sections above or have edited/removed them in a way that fully describes the issue.
• [x] Generated debugging information by executing Atom Beautify: Help Debug Editor command in Atom and added link for debug.md Gist to this issue

[ghost]

Please follow the issue template provided. More specifically, update the original comment for this issue by adding a link to the required debug.md gist which includes debugging information that answers our most commonly asked questions. Thank you.

[chuhta]

I fixed the issue, but the label doesn't appear to be getting removed by the bot.

[probot-no-response[bot]]

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.