Glavin001 / atom-beautify

:mega: Help Wanted - Looking for Maintainer: https://github.com/Glavin001/atom-beautify/issues/2572 | :lipstick: Universal beautification package for Atom editor (:warning: Currently migrating to https://github.com/Unibeautify/ and have very limited bandwidth for Atom-Beautify Issues. Thank you for your patience and understanding :heart: )
http://unibeautify.com/
MIT License
1.5k stars 453 forks source link

Beautifier adding unneeded backslash to SASS and SCSS code #2352

Open Richienb opened 5 years ago

Richienb commented 5 years ago

Description

The beautifier is adding an unneeded \ to SASS and SCSS code. The \ makes the code invalid according to stylelint:

×  Unexpected unknown type selector "\:"   selector-type-no-unknown

Input Before Beautification

This is what the code looked like before:

html
  ::selection
    color: white

Expected Output

The beautified code should have looked like this:

html
  ::selection
    color: white

Actual Output

The beautified code actually looked like this:

html
  \::selection
    color: white

Steps to Reproduce

  1. Add code to Atom editor
  2. Run command Atom Beautify: Beautify Editor
  3. This beautified code does not look right!

Debug

Here is a link to the debug.md Gist: https://gist.github.com/Richienb/ddfa4898b537eedbff86998849cb2607

Checklist

I have:

prettydiff commented 5 years ago

It seems from https://github.com/SassDoc/sass-convert/issues/23 that SassConvert is deprecated, it does not look like this defect will be resolved.

pascalduez commented 5 years ago

@prettydiff Looks like atom-beautify is using sassconvert as a dependency, not sass-convert. :confused:

prettydiff commented 5 years ago

Link me to the correct project please,

pascalduez commented 5 years ago

@prettydiff My bad, I though it was an npm package. Still I don't see Sassdoc's sass-convert being used here, instead directly the old Ruby Sass binary.