search

Glavin001 / atom-beautify

:mega: Help Wanted - Looking for Maintainer: https://github.com/Glavin001/atom-beautify/issues/2572 | :lipstick: Universal beautification package for Atom editor (:warning: Currently migrating to https://github.com/Unibeautify/ and have very limited bandwidth for Atom-Beautify Issues. Thank you for your patience and understanding :heart: )
http://unibeautify.com/
MIT License
1.5k stars 453 forks source link

Slim support (ruby slim) #634

Open riley-usagi opened 9 years ago

riley-usagi commented 9 years ago

This would be awesome.

phoenixweiss commented 8 years ago

I think the same way!

outwitevil commented 8 years ago

Me too

prettydiff commented 8 years ago

The language appears to be: http://slim-lang.com/ which looks similar to Jade and would require a similar beautifier.

rtack commented 8 years ago

Were the changes in https://github.com/Glavin001/atom-beautify/commit/d48768e5034e59f2c618c7d56c05693879441124 all that is required to add support for Jade? Or is the comment in #199 "I haven't had a chance to finish adding Jade support. However, I have moved this back to v0.29.0 milestone, so I want it to be in the next release." indicating the support is not fully implemented yet?

prettydiff commented 8 years ago

@Glavin001 could answer the prior questions better.

Glavin001 commented 8 years ago

@rtack : That commit does add support for Jade. Before I made that comment I had not implemented Jade support, however after seeing how many users requested it and also that Pug-beautify package was published, I figured I would quickly implement and publish it. Hopefully it is working well for users.

rtack commented 8 years ago

wondering how much effort it would be to implement this for slim. Am I correct that the actual code who does the formatting is at https://github.com/vingorius/pug-beautify/blob/master/index.js ?

Glavin001 commented 8 years ago

@rtack : Yes the code that formats/beautifies Jade/Pug language is the pug-beautify package you linked to there. You could talk with the maintainer and Slim does look very similar to hopefully you can work out a solution! That would be great!

preston commented 8 years ago

+1 for built-in Slim support!

fmatosic commented 8 years ago

+1 for built-in Slim support!

Glavin001 commented 8 years ago

Please note that +1s do not help this feature become reality. Atom-Beautify requires a third-party beautifier to exist and be integrated into Atom-Beautify for use.

With that in mind, how you can turn this feature request into a feature is by: 1) finding a beautifier that works 2) submitting a Pull Request to Atom-Beautify such that you can use it

As noted, pug-beautify may work. I recommend that each of you go +1 an issue over at https://github.com/vingorius/pug-beautify/blob/master/index.js (or create an issue if necessary). Once pug-beautify supports Slim, then come back and add support to Atom-Beautify with a Pull Request. Thank you.