search

Glavin001 / atom-beautify

:mega: Help Wanted - Looking for Maintainer: https://github.com/Glavin001/atom-beautify/issues/2572 | :lipstick: Universal beautification package for Atom editor (:warning: Currently migrating to https://github.com/Unibeautify/ and have very limited bandwidth for Atom-Beautify Issues. Thank you for your patience and understanding :heart: )
http://unibeautify.com/
MIT License
1.5k stars 453 forks source link

Dojo unsupported script types. #805

Closed lethevimlet closed 6 years ago

lethevimlet commented 8 years ago

Dojo Toolkit uses script type=”dojo/method” and script type=”dojo/aspect” since this is not a default this will cause formatting issues.

dojo/method and dojo/aspect is highly used when working with Dojo Toolkit, as described in

https://dojotoolkit.org/reference-guide/1.10/dijit/Declaration.html

It can be easily fixed like so (line 504 of beautify-html.js) tag_complete.search(/\b(text|application|dojo)\/(x-)?(javascript|ecmascript|jscript|livescript|(ld\+)?json|method|aspect)/) > -1))) {

Ideally atom-beautify shouldn't attempt to format unknown types since in worst case scenario the formatting would be omitted while if wrong formatting is applied to an unknown type code will get messed up affecting its functionality.

prettydiff commented 8 years ago

Notifying @bitwiseman

lethevimlet commented 8 years ago

I opened an issue on js-beautify github since atom-beautify depends on it. https://github.com/beautify-web/js-beautify/issues/874

stale[bot] commented 6 years ago

This issue has been automatically marked as stale because it has not had recent activity. If this is still an issue, please add a comment. It will be closed if no further activity occurs. Thank you for your contributions.