search

Glavin001 / atom-beautify

:mega: Help Wanted - Looking for Maintainer: https://github.com/Glavin001/atom-beautify/issues/2572 | :lipstick: Universal beautification package for Atom editor (:warning: Currently migrating to https://github.com/Unibeautify/ and have very limited bandwidth for Atom-Beautify Issues. Thank you for your patience and understanding :heart: )
http://unibeautify.com/
MIT License
1.5k stars 453 forks source link

Demandware language support (.isml & .ds) #923

Open AaronV opened 8 years ago

AaronV commented 8 years ago

Description

Any chance of support for Demandware languages: .isml and .ds. These are very similar to .html and .js respectively.

prettydiff commented 8 years ago

Would you happen to have a link to the language spec? It would help us evaluate if additional support is needed or if the language can be supported directly in existing beautifiers.

AaronV commented 8 years ago

Unfortunately, I've found relatively little information about the spec. The best I've seen is for ISML and is a list of their custom tags and this bit of description.

Demandware ISML tags are extensions of the tag-based language conforming to SGML standards. They are commands inserted into a document that determine how Demandware eCommerce embeds live data into a page, and how to format this data together with the regular HTML code.

Is that enough to roll it into the HTML beautifier?

prettydiff commented 8 years ago

The currently supported HTML beautifiers are:

Try running some code samples through those tools. If the code samples aren't mutilated then we can presume support from current beautifiers.

AaronV commented 8 years ago

PrettyDiff seems to work fairly well for .isml and .ds files. Is it user-configurable to get those the html & js beautifiers working for those file-types? I ran into some cases where it didn't work well and wouldn't want to force those beautifiers on everyone using my workflow.

prettydiff commented 8 years ago

I recommend opening issues at one of those projects:

Please open an issue for any defect you notice with code samples.

AaronV commented 8 years ago

Thanks, Austin. Should this ticket be closed in the meantime?

prettydiff commented 8 years ago

No, leave this issue open and link to this issue from the beautifier specific issue.

prettydiff commented 5 years ago

It looks like Demandware was acquired by SalesForce in the months after this ticket was created. Is Demandware still a thing? If so is there a location for isml or ds documentation?

zetxek commented 5 years ago

It is - now it's called Salesforce Commerce Cloud B2C. The syntax is still the same: .isml for template languages, /ds for legacy javascript (the new code is usually named .js)

prettydiff commented 5 years ago

@zetxek Do you know if there is a link to describes the isml spec? I was on that site earlier today, but I could not find the documentation.

zetxek commented 5 years ago

@prettydiff the docs are behind an NDA - but I can share that it's an extension of the SGML, with some specific additional tags that are valid for the syntax. Basically it's HTML + some proprietary tags (which can be both self closing or in the long format <tag>whateverinside</tag>).

I'm wondering if we could extract the syntax for an old Eclipse plugin that has syntax highlighting.

prettydiff commented 5 years ago

To make this work I just need to know which tag names are self closing, because otherwise they will be treated as start tags without an ending pair. I can make this work in much the same way I extended support for ColdFusion's CFML.

I could also contact SalesForce and ask for an NDA to sign if they are willing to allow me to do this work.