search

Glavin001 / atom-preview

:construction: (NO LONGER MAINTAINED) :construction: - :eyeglasses: Ultimate previewer of source code in Atom.
https://atom.io/packages/preview
MIT License
51 stars 23 forks source link

Preserve line-breaks in compiler error messages #102

Closed darrencruse closed 8 years ago

darrencruse commented 9 years ago

Pull request for issue #100 https://github.com/Glavin001/atom-preview/issues/100

Now error messages are much easier to read overall without the center alignment, esp. those that attempt to format a caret beneath the offending character in the line e.g. Coffescript.

Also: per our discussion in the issue above, I added just some minimal styles necessary to achieve the formatting (which was to left align the text, plus expanding the message overlay to fill the entire preview tab).

The rest of the formatting still comes from the styles in their theme.

I did confirm I could change the theme and and the error messages still looked fine.

@Glavin001 ready for review

Glavin001 commented 8 years ago

Looks good!

image

image

Thank you for contributing!

Glavin001 commented 8 years ago

Published to v0.16.3