search

Glavin001 / atom-preview

:construction: (NO LONGER MAINTAINED) :construction: - :eyeglasses: Ultimate previewer of source code in Atom.
https://atom.io/packages/preview
MIT License
51 stars 23 forks source link

Promise.done is deprecated. #133

Closed mikedizon closed 2 years ago

mikedizon commented 7 years ago

Atom now uses ES6 Promises instead of Q. Call promise.then instead of promise.done

Promise.done (/Applications/Atom.app/Contents/Resources/app.asar/src/atom-environment.js:1214:5)
Object.toggle (/Users/mdizon/.atom/packages/preview/lib/preview.coffee:109:10)
atom-workspace.atom.commands.add.preview:toggle (/Users/mdizon/.atom/packages/preview/lib/preview.coffee:36:26)
CommandRegistry.handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:259:29)
handleCommandEvent (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:3:59)
CommandRegistry.dispatch (/Applications/Atom.app/Contents/Resources/app.asar/src/command-registry.js:160:19)
jwverzijden commented 5 years ago

why is this still in there? promises have been around for a while now

thwaller commented 3 years ago

Is there any update on this?