search

Glavin001 / atom-preview

:construction: (NO LONGER MAINTAINED) :construction: - :eyeglasses: Ultimate previewer of source code in Atom.
https://atom.io/packages/preview
MIT License
51 stars 23 forks source link

Preview shouldn't be focused #49

Closed danielbrodin closed 10 years ago

danielbrodin commented 10 years ago

Looked through the Atom core some and from my testing this seems to fix issue #48 for me. Haven't done any large testing though so might cause other issues that I haven't noticed.

Glavin001 commented 10 years ago

Thanks @danielbrodin! I will test now and publish if it works as expected.

ddavison commented 10 years ago

I can confirm it works

Glavin001 commented 10 years ago

Thanks for testing @ddavison. Since I cannot reproduce and both of you have confirmed it is working, I'll publish the patch now :+1:.

Glavin001 commented 10 years ago

I am able to reproduce on my work computer with v0.10.2

Glavin001 commented 10 years ago

Published to v0.10.3 and confirmed it is also fixing the issue for me. Great work @danielbrodin! Thanks again!

danielbrodin commented 10 years ago

No problem, glad it fixed it :)

Glavin001 commented 10 years ago

@danielbrodin are you noticing any weird UI glitches (line goes blank) when you put your cursor in a Preview? It may be another package, but on my work laptop with this fix applied, it will remove the style attribute's previous value and replace with only background-color and value, which results in a disappearing line on click/cursor move.

danielbrodin commented 10 years ago

@Glavin001 This is how it looks for me preview

Glavin001 commented 10 years ago

That looks good. Must be a broken package on my end. Will play around and find out. Thanks for sharing a screenshot, @danielbrodin.

danielbayley commented 9 years ago

@Glavin001 Preview still steals focus for me, despite this. Any idea why?

Glavin001 commented 9 years ago

@danielbayley Create a new Issue and let's start a discussion. I would like to investigate this further. Maybe Atom has a new API now that it is v1.0 that we could use that would resolve this for good :+1:. Thanks for letting me know.

danielbayley commented 9 years ago

@Glavin001 Done :thumbsup: