update ember/ember-cli versions

Glavin001 / ember-c3

:chart_with_upwards_trend: Ember addon library for C3, a D3-based reusable chart library.

http://glavin001.github.io/ember-c3/

MIT License

81 stars 60 forks source link

update ember/ember-cli versions #75

Closed yratanov closed 5 years ago

yratanov commented 6 years ago

use c3 from npm
fix import warnings
fix issued when _reload was called on a component in destrpyed/isDestroying state
fix animation glitch because didReceiveAttrs is called every time attrs update
remove all bower dependencies except of jsoneditor

yratanov commented 6 years ago

I wasn't able to update jsoneditor addon version because of a bower error. Though old version is working fine.

If you are happy with my changes, I'd like to continue my contribution by adding some tests, fixing dummy app eslint errors, etc.

maxwondercorn commented 6 years ago

I was also updating this but I got busy and didn't get back to it. I need to review this PR with my changes before a merge. It looks like you got most of the changes.

Add this directive to the dummy app controllers to fix the eslint errors:

/* eslint ember/avoid-leaking-state-in-ember-objects: "off" */

I had not converted from Bower but using ember-cli-cjs-transform might be better than the ember-browserify trick.

I've updated the dummy app to demonstrate how to use actions as callbacks, rather just the console.log for mouseover, mouseexit, onclick, etc.

Tests would be great

yratanov commented 6 years ago

@maxwondercorn

ember-cli-cjs-transform is awesome! didn't know about it. Replaced ember-browserify with it.

oakho commented 5 years ago

Hey guys,

Any chance for you to merge this one soon ? I'm in the process to moving an app to ember 3 and would be nice to have an up to date version of this addon we are using in it !

Thanks

maxwondercorn commented 5 years ago

I thought I would have time to work on this all sooner but work and life got in the way. Since 3.4 in now LTS we should be on v3. I hope to get back to this in November, when I'll have a couple solid weekends to work on it.

oakho commented 5 years ago

No problem, I understand. Let me know if I can help in anyway. Thanks.

Paskalouis commented 5 years ago

Hi, I am happy that this PR is still up. Will this PR be merged soon? @Glavin001 @maxwondercorn are you working to continue things on this PR?

Thank you !

maxwondercorn commented 5 years ago

See issue #77