GleapSDK / ReactNative-SDK

Other
13 stars 5 forks source link

Add ability to disable showing the menu on shake #1

Open sethcwhiting opened 2 years ago

sethcwhiting commented 2 years ago

Hey thanks for making this! It's super helpful/useful.

One request: We have a button on our app that makes use of the Gleap.open() functionality, and would prefer to only use that and not make use of the "shake device to open menu" functionality. Would it be possible to get that in an update?

(P.S. My apologies if this is already possible and I just missed it.)

boehlerlukas commented 2 years ago

Hey @sethcwhiting !

Sorry for the late reply. This is possible already :) Simply open your project in the Gleap dashboard and navigate to "Widget configuration" -> "Advanced" and then select "App SDK". Now you can enable and disable the activation methods.

In addition to that we will also add methods to enable & disable these options programmatically within the next few days.

Bildschirmfoto 2022-03-13 um 11 22 19
sethcwhiting commented 2 years ago

@boehlerlukas Thanks so much! I'll go flip that switch!

boehlerlukas commented 2 years ago

@sethcwhiting Awesome! I will let you know once we also implemented the methods for manual overwriting these settings.

seemX17 commented 10 months ago

When I disable the switch I can still see the shake gesture working

boehlerlukas commented 10 months ago

Hey @seemX17 :)

After turning the switch off and saving, you will need to restart the app. You might also want to try turning it on /off once more, just to make sure it's not some sort of caching issue. (the config needs to reload).

Let me know if it still doesn't work :)

seemX17 commented 10 months ago

We are using react-native-gleapsdk:13.1.1 and it doesn't seem to work on Android but works fine on iOS @boehlerlukas

boehlerlukas commented 10 months ago

@seemX17 thanks for the update! We will look into it right tomorrow morning :) Will update you asap.

boehlerlukas commented 10 months ago

Hey @seemX17 ,

Could you try with the new RN release (v13.2.1). We were actually not able to reproduce the issue on Android (we tested on multiple phones).

Also please make sure to run pod install --repo-update and update gradle to get the latest native dependencies :)

seemX17 commented 9 months ago

Hi @boehlerlukas , It is possible that this bug occurs because we have two different tokens. The flow is the following Open the app -> User is not logged in -> initialized with a projectA token User logs in -> Initialized with projectB token This scenario works fine on iOS . Is there a systematic way to reset with a new token?

boehlerlukas commented 9 months ago

Hey @seemX17

That might be the case - it's actually not even fully supported doing the initialization twice - this usually leads to more issues etc. Could you test if it works if you don't do this? Also: could you share some more details on why you need to have two different projects for logged in / logged out? Usually it's easier to manage to have one project in that scenario :) A lot of the content can be adjusted based on audience rules.

Happy to hear back from you :)

seemX17 commented 9 months ago

It works if we have only one initialization. In the app, there are two different companies and they want their respective Gleap accounts hence the two different projects. One is general and the other account is company-specific so we need two different projects. @boehlerlukas