Glease / TC4Tweaks

A mod that adds a bit of functionality and a bit of performance into thaumcraft 4.
https://www.curseforge.com/minecraft/mc-mods/tc4tweaks
GNU Affero General Public License v3.0
10 stars 9 forks source link

[SUGGESTION] (1) Unloading Vis Relay network + (2) Pickaxe of the Core not using oredict for Iron Ore #17

Open Shazuli opened 3 years ago

Shazuli commented 3 years ago

Is your feature request related to a problem? Please describe.

  1. The biggest problem with Vis Relays is when they are spread out over multiple chunks some gets unloaded while others remain loaded and lose their connection with that relay, resulting in it trying to connect to a new relay. You also get some strange artifacts where some relays gets cut of completely from the source Node but still have a visual connection with no power.

Indented relay network layout: 2021-07-31_10 02 36 2021-07-31_10 03 11

After a quick ~14 chunks travel: 2021-07-31_14 48 56 2021-07-31_14 49 18

  1. From testing it appears that mining a Native Cluster with the Pickaxe of the Core only works with vanilla Iron Ore and not with ore dictionary Iron Ore. Other ores such as Gold Ore from other mods work fine. It should be noted creating the Native Cluster in the Crucible works with ore dictionary, just not creating them by mining the ore with Pickaxe of the Core.

Describe the solution you'd like

  1. Vis Relay networks should be able to handle unloading of surrounding chunks.

  2. Other mods' Iron Ore should be possible to turn into Native Iron Clusters using Pickaxe of the Core.

Describe alternatives you've considered

  1. A solution to this problem could be so a relay has a preferred relay to connect to. And if it can't it will try to connect to another available. And every once in a while (let's say every 30 seconds) it will try to connect to its preferred relay. And after n amount of failed attempts to connect to its preferred relay, it will select the currently connected relay as its preferred. Should be less likely to break.

  2. Have so the Pickaxe of the Core use ore:oreIron instead of minecraft:iron_ore.

Glease commented 3 years ago

Vis relay would be a welcomed change. Not sure what's wrong with pickaxe of core though. Will look into them once I fixed my computer.

Shazuli commented 3 years ago

The Vis Relay change probably should have a config to turn it on and off. I think the solution I came up with would be an improvement to their current behaviour (you probably have a better how to improve Vis Relays), but some might not like that change. Maybe have it as an experimental mechanic you have to turn on in options?

Or what if Vis Relay doesn't automatically connect to other relays? Immersive Engineering and many other mods that use nodes that connect between them uses a cable item of sort to create a connection. But what if you could shift-right-click with a wand on a Vis Relay to start "linking mode" of sort to create connections? Botania does exactly that with Wand of the Forest. You shift-right-click one block and then another block to have the first block point to the second. It's obviously more work for the player, but it will never break when chunks unloads, and you don't have to mess around placing random block to prevent an undesired connection.

Maybe a config option which by default is set to 0 (Thaumcraft's Vis Relay mechanics (normal behaviour)). If you set it to 1 you have smart Vis Relays (first suggestion) and 2 is manual where you have to create connections manually with a wand (or maybe a Balanced Shard, that makes sense too I guess).

Glease commented 3 years ago

For now I'll try to make vis relays not forget their parents, and if that succeeded there is no reason to complicate it too much.

Glease commented 3 years ago

I have looked into the pickaxe of core. It simply just won't do any oredict lookup at all. No idea why it would pick oredict equivalents for gold ore. Maybe one of other TC4 addons you are using are trying to help you overcome this problem, but somehow missed iron ore.

Shazuli commented 3 years ago

@Glease Hmm... that's strange. I guess mods like Witching Gadgets could be the one responsible. You think you could have so it uses OreDict anyways? It would still be an improvement to regular Thaumcraft.

Edit

Just thought of a way to over-complicate it: In the configs you can tell it when it mines a block/OreDict block it will have a chance to turn into "this" item.

{
    "pickaxe_of_the_core_transmutations" : [
        { "input": ["ore:oreIron"], "output": "thaumcraft:native_iron_cluster"},
        { "input": ["ore:oreGold"], "output": "thaumcraft:native_gold_cluster"},
        { "input": ["minecraft:planks:0","minecraft:log:0"], "output": "minecraft:stick"}
    ]
}

This would be great for modpack creators. The bonus is you can make special transmutations that is not part of regular Thaumcraft, like modded ores for example. And you can remove stuff from the list too so two mods don't do the same thing (if Witching Gadgets make their own transmutations you don't have to make a rule for Gold Ore).

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 3 days

Shazuli commented 3 years ago

Have you thought anything more about that idea? Perhaps not as convoluted like I explained it, but perhaps something similar?

github-actions[bot] commented 3 years ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 3 days

Glease commented 3 years ago

Not really. Was busy with IRL matter and general development of other GTNH mods.

Glease commented 3 years ago

WTF why this is closed.