Glease / TC4Tweaks

A mod that adds a bit of functionality and a bit of performance into thaumcraft 4.
https://www.curseforge.com/minecraft/mc-mods/tc4tweaks
GNU Affero General Public License v3.0
10 stars 9 forks source link

Primal Crusher/Chameleon tools impact not harvesting GT ores #31

Open Zero-ui9 opened 1 year ago

Zero-ui9 commented 1 year ago

Is your feature request related to a problem? Please describe.

As title states, neither the primal crusher nor a chameleon pickaxe enchanted with impact will harvest GT ores(or actually any tileentity) with their 3x3 mining effect.

Describe the solution you'd like

From what I can tell, this behavior is due to the "harvestBlock" method in thaumcraft/common/lib/utils/BlockUtils (though I'm not entirely fluent in java, and it's obfuscated, so correct me if I'm wrong), which I believe just returns false for tile entities (but is also responsible for the "item collection" effect these tools have), and forbidden magic just calls the same method from TC.

Glease commented 1 year ago

It's hard to say what to do with this. Maybe allow a whitelist...?

Zero-ui9 commented 1 year ago

either that, or just copy whatever tinkers does, I know the hammer does something completely different. also found out this effect ignores endstone, just as if it was also a tile entity

hron84 commented 1 year ago

Wait, I thought GT ores aren't tile entities. Are they?

Glease commented 1 year ago

image