search

GlenKPeterson / PdfLayoutManager

Adds line-breaking, page-breaking, tables, and styles to PDFBox
45 stars 20 forks source link

logicalPageEnd is not accessible #2

Closed wienczny closed 9 years ago

wienczny commented 9 years ago

LogicalPageEnd has package scope and is not accessible outside of com.planbase.pdf.layoutmanager. It is used by the Example-Code. If you dig deeper into the code you will see that LogicalPage has a method commit that calls LogicalPageEnd. Either LogicalPageEnd shoud be public or the sample should use LogicalPage#commit

GlenKPeterson commented 9 years ago

Thank you so much for your clear and helpful issue report! I changed the sample code to use lp.commit();, moved the sample code to the top-level package to prevent it from ever accessing package-scoped items again, and bumped the most minor version number.