GlenKPeterson
commented
9 years ago Thank you for your kind words. Good catch! The best solution might be to make PdfLayoutMgr implement AutoCloseable and update the sample app/test appropriately to use the new try-with-resources syntax. Maybe save() should call close() as well. Is a PdfLayoutMgr even valid after a call to save()? I can't remember, but there is no point in making users call two methods if one method call will do. Maybe save() should be renamed close() and call doc.close() internally?
I was away for a few days, but can probably fix it this weekend, or you could submit a patch.
Thanks so much for making this project available. I was looking for a PdfBox front-end and this seems to go a long way to doing just about everything I'm looking for. Even if I don't end up using it directly, what I am learning by looking at the code is hugely speeding up my grasp of PdfBox.
One thing: I noticed when playing with pdfLayoutTest.testPdf that I was getting warnings from PdfBox about the document not getting closed. I had taken the code and just tweaked it a bit to serve the PDF from a servlet, and the warnings were output by Jetty whenever I restarted the server.
Is this a problem? If so, as an easy remedy, I think you can simply add a close method to PdfLayoutMgr that just does a doc.close(). Users of the class will need to remember to do it... just like they would if using PdfBox directly.