search

Glench / Vim-Jinja2-Syntax

An up-to-date jinja2 syntax file.
https://github.com/mitsuhiko/jinja2
BSD 3-Clause "New" or "Revised" License
343 stars 64 forks source link

Set commentstring to the default block comment syntax. #31

Closed averms closed 3 years ago

averms commented 3 years ago

Before it was ## which isn't even part of the Jinja syntax by default https://jinja.palletsprojects.com/en/2.11.x/templates/#comments.

Glench commented 3 years ago

huh, wonder how that never came up before. thanks for fixing!

averms commented 3 years ago

Wait no I screwed up, it should be {#%s#}. Attached is a patch that fixes.

0001-Fix-bad-commentstring.patch.txt

Glench commented 3 years ago

Can you open another pull request so there’s more of a record of the change?

On Wed, Oct 14, 2020 at 00:10 a-vrma notifications@github.com wrote:

Wait no I screwed up, it should be {#%s#}. Attached is a patch that fixes.

0001-Fix-bad-commentstring.patch.txt https://github.com/Glench/Vim-Jinja2-Syntax/files/5375529/0001-Fix-bad-commentstring.patch.txt

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/Glench/Vim-Jinja2-Syntax/pull/31#issuecomment-708143871, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADOHBIYUXMB2SNS5CJPZT3SKUQBZANCNFSM4SNN3UXA .

averms commented 3 years ago

yeah sure #32